-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
login poc #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cleve Stuart <[email protected]>
Co-authored-by: Cleve Stuart <[email protected]>
adding tests in another pr |
echo-bravo-yahoo
approved these changes
Oct 1, 2024
Merged
echo-bravo-yahoo
added a commit
that referenced
this pull request
Oct 4, 2024
* poc for new login auth * remove unused code from poc * no need client secret for auth code * some fixups * better port selection * avoid race condition * Update src/commands/login.ts Co-authored-by: Cleve Stuart <[email protected]> * Update src/commands/login.ts Co-authored-by: Cleve Stuart <[email protected]> * surface error_description and leverage open() to for oauth prompt * move login command to yargs --------- Co-authored-by: Cleve Stuart <[email protected]> Co-authored-by: Ashton Eby <[email protected]>
Closed
This was referenced Dec 2, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #364 that was closed, against new
v3
branch changesTicket(s): FE-5879
new_session_tokens
is not turned onOut of Scope
In another PR i'll break some of this out to a new frontdoor client where I can add unit tests and other methods like refresh session
Screen.Recording.2024-09-23.at.1.27.00.PM.mov