Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login poc #370

Merged
merged 12 commits into from
Oct 1, 2024
Merged

login poc #370

merged 12 commits into from
Oct 1, 2024

Conversation

mwilde345
Copy link
Member

@mwilde345 mwilde345 commented Sep 30, 2024

Copy of #364 that was closed, against new v3 branch changes

Ticket(s): FE-5879

  • Basic interface to call frontdoor auth code, token and session endpoints.
  • Only works locally as frontdoor only knows about the local client id.
  • Fails if new_session_tokens is not turned on

Out of Scope

In another PR i'll break some of this out to a new frontdoor client where I can add unit tests and other methods like refresh session

Screen.Recording.2024-09-23.at.1.27.00.PM.mov

src/lib/auth/oauth-client.ts Outdated Show resolved Hide resolved
src/commands/login.ts Outdated Show resolved Hide resolved
src/commands/login.ts Outdated Show resolved Hide resolved
@mwilde345 mwilde345 marked this pull request as ready for review October 1, 2024 17:08
@mwilde345
Copy link
Member Author

adding tests in another pr

@mwilde345 mwilde345 merged commit e383e1b into v3 Oct 1, 2024
1 check failed
@mwilde345 mwilde345 deleted the login-poc branch October 1, 2024 17:36
@mwilde345 mwilde345 mentioned this pull request Oct 2, 2024
echo-bravo-yahoo added a commit that referenced this pull request Oct 4, 2024
* poc for new login auth

* remove unused code from poc

* no need client secret for auth code

* some fixups

* better port selection

* avoid race condition

* Update src/commands/login.ts

Co-authored-by: Cleve Stuart <[email protected]>

* Update src/commands/login.ts

Co-authored-by: Cleve Stuart <[email protected]>

* surface error_description and leverage open() to for oauth prompt

* move login command to yargs

---------

Co-authored-by: Cleve Stuart <[email protected]>
Co-authored-by: Ashton Eby <[email protected]>
This was referenced Nov 18, 2024
@cleve-fauna cleve-fauna mentioned this pull request Nov 22, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 5, 2024
This was referenced Dec 6, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants