Makefile.cross-compiles: Fix softfloat flag not being honored for mipsle #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
fatedier
approved these changes
Apr 22, 2024
11 tasks
github-actions bot
added a commit
to aiastia-dockerhub/frp
that referenced
this pull request
Apr 22, 2024
* https://github.com/fatedier/frp: Makefile.cross-compiles: Fix softfloat flag not being honored for mipsle. (fatedier#4176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
When building using Makefile.cross-compiles, softfloat flag was being applied only to "mips" big-endian builds but not "mipsle" little-endian builds despite the flag being set in architecture list. This resulted in binaries which would not run on target machines without a FPU or a FPU emulator in kernel.
This change fixes the "if" statement in Makefile.cross-compiles to correctly apply the softfloat flag to both "mips" and "mipsle" builds.
Binaries run fine on a system with a BCM4706 MIPS SoC.