Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mipsle arch is missing softfloat flag due to Makefile.cross-compiles bug #4175

Closed
3 of 11 tasks
ddscentral opened this issue Apr 22, 2024 · 3 comments · Fixed by #4176
Closed
3 of 11 tasks

mipsle arch is missing softfloat flag due to Makefile.cross-compiles bug #4175

ddscentral opened this issue Apr 22, 2024 · 3 comments · Fixed by #4176
Labels

Comments

@ddscentral
Copy link
Contributor

Bug Description

In Makefile.cross-compiles even though both mips and mipsle have softfloat flag, it is only applied for "mips" due to a bug in "if statement.

Line

 elif [ "$${os}" = "linux" ] && [ "$${arch}" = "mips" ] && [ "$${extra}" != "" ] ; then \

should look like this:

 elif [ "$${os}" = "linux" ] && ([ "$${arch}" = "mips" ] || [ "$${arch}" = "mipsle" ]) && [ "$${extra}" != "" ] ; then \

frpc Version

0.57.0

frps Version

0.57.0

System Architecture

linux/mipsel

Configurations

Not applicable

Logs

No response

Steps to reproduce

  1. Run make -f Makefile.cross-compiles
  2. Copy mipsle binary (any frps or frpc) to a MIPS device without a FPU
  3. Binary does not run due to "illegal instruction".

Affected area

  • Docs
  • Installation
  • Performance and Scalability
  • Security
  • User Experience
  • Test and Release
  • Developer Infrastructure
  • Client Plugin
  • Server Plugin
  • Extensions
  • Others
@ddscentral
Copy link
Contributor Author

With the line corrected, binaries do run on the device.

@fatedier
Copy link
Owner

Can you submit a PR to fix it?

@fatedier fatedier added the todo label Apr 22, 2024
@ddscentral
Copy link
Contributor Author

Created a PR: #4176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants