fix: if serve: false and root is not defined, only allow sending files with absolute path #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with absolute path
ilteoood
reviewed
Oct 15, 2025
Contributor
Author
|
I would like to have a review by @climba03003 or @is2ei regarding the security aspect. |
Contributor
|
I think @climba03003 would be the right person, as he originally mentioned the security concern. |
Contributor
Author
|
I pinged him on discord. Lets see if he has time. |
2 tasks
Uzlopak
commented
Oct 16, 2025
Contributor
Author
|
@is2ei |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If serve is set to false, it only allows to send files specified with an absolute path. Or else sendFile makes no sense anymore, despite that we want to allow the use of sendFile.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct