Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using serve: false, root should be optional #460

Open
2 tasks done
tonttu opened this issue Aug 19, 2024 · 2 comments
Open
2 tasks done

When using serve: false, root should be optional #460

tonttu opened this issue Aug 19, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@tonttu
Copy link

tonttu commented Aug 19, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

I just want to use the sendFile decorator without serving any files automatically, so I set serve: false. However, I still need to provide a valid path to root, otherwise checkRootPathForErrors complains. Now I resort to creating a dummy directory in tmpdir() just to keep this plugin happy, which seems a bit silly.

I think if serve: false is defined, checkRootPathForErrors should not be called at all.

Motivation

No response

Example

No response

@mcollina
Copy link
Member

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@tonttu
Copy link
Author

tonttu commented Aug 19, 2024

Thank's for the quick response. I'm currently short on time and I don't think I'll be able to submit a PR at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants