Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exports #103

Merged
merged 6 commits into from
Oct 6, 2022
Merged

Fix exports #103

merged 6 commits into from
Oct 6, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 6, 2022

Superseeds #102

Checklist

@Uzlopak Uzlopak mentioned this pull request Oct 6, 2022
Closed
4 tasks
climba03003
climba03003 requested changes Oct 6, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep module.exports.fastifySchedulePlugin at this moment.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 6, 2022

Or we should decide to release a new major?

@climba03003
Copy link
Member

climba03003 commented Oct 6, 2022 •
edited
Loading

Or we should decide to release a new major?

It doesn't hurt for one more named exports.
I would encourage a major only for feature changes but not a patch like export.

Basically, the problem only need to release a new version.
It doesn't even need any code changes.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 6, 2022

better?

@Uzlopak Uzlopak merged commit 8672fb9 into main Oct 6, 2022
@Uzlopak Uzlopak deleted the fix-exports branch October 6, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climba03003 climba03003 climba03003 approved these changes

@kibertoad kibertoad Awaiting requested review from kibertoad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @climba03003