-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update type declarations #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typing should be correct for fastify-plugin@4
, it just require a new release.
Yes you are right. |
I think #103 will fix it properly |
As you can see here, there is sth named |
Dont worry. The issue is that we should have exported the code differently. |
@Uzlopak okay, thank you 😺 Am I supposed to close this PR? |
|
export default fastifySchedule; | ||
export { fastifySchedule }; | ||
export default fastifySchedulePlugin; | ||
export { fastifySchedulePlugin }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export { fastifySchedulePlugin }; | |
export { fastifySchedule, fastifySchedulePlugin }; |
There was import issue on TypeScript, because type declarations doesn't match actual implementations. PR solves this issue.
Checklist
npm run test
andnpm run lint:everything
and the Code of conduct