ci: move to github action #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove support of EOL node - add support of node 12, 14 - move to github action
zekth
requested changes
Oct 9, 2020
| @@ -0,0 +1,18 @@ | |||
| name: CI workflow | |||
| on: [push, pull_request] | |||
Member
Author
There was a problem hiding this comment.
@zekth I think branch target should not be added because it will not trigger the test for dependent bot.
Member
There was a problem hiding this comment.
dependabot will be triggered by the pull_request trigger. In this case you'll have double ci execution. One for the push on the branch another one on the pull request event.
Member
Author
There was a problem hiding this comment.
I do not think it will trigger twice, you can compare the setting across the fastify repositories.
All of them do not have the branch target and also they do not trigger twice.
I don't think we should treat it special in this plugin.
Member
There was a problem hiding this comment.
ok, so this bug has been fixed in GH actions.
zekth
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct