Skip to content

feat: 🏷️ add typing #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Eomm merged 4 commits into from
Oct 10, 2020
Merged

feat: 🏷️ add typing #14

Eomm merged 4 commits into from
Oct 10, 2020

Conversation

@climba03003
Copy link
Member

@climba03003 climba03003 commented Oct 9, 2020 •
edited
Loading

Add typing for fastify/fastify-env#69 to reflect.

Checklist

@climba03003
Copy link
Member Author

climba03003 commented Oct 9, 2020 •
edited
Loading

Fail because of dependency tsd.
Should this plugin move to GitHub actions? and also remove support for node 6 and node 8?

@Eomm
Copy link
Member

Eomm commented Oct 9, 2020

Should this plugin move to GitHub actions? and also remove support for node 6 and node 8?

Yes, we should revamp the dependencies and drop node at EOL stage in another PR before merging this one
Then we can bump a major 👍

@climba03003
Copy link
Member Author

climba03003 commented Oct 9, 2020

Should this plugin move to GitHub actions? and also remove support for node 6 and node 8?

Yes, we should revamp the dependencies and drop node at EOL stage in another PR before merging this one
Then we can bump a major 👍

I have created the related PR #15 , please check it. Thanks.

mcollina
mcollina approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RafaelGSS
RafaelGSS approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eomm Eomm merged commit 62b3f89 into fastify:master Oct 10, 2020
@voxpelli voxpelli mentioned this pull request Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@climba03003 @Eomm @mcollina @RafaelGSS