⬆ Upgrade Starlette from 0.18.0 to 0.19.0 by Kludex · Pull Request #4488 · fastapi/fastapi

Kludex · 2022-01-27T19:24:51Z

Set of breaking changes:

~~Starlette 0.19.0 is not released yet. Feel free to ignore this for now.~~

codecov · 2022-01-27T19:33:11Z

Codecov Report

Merging #4488 (fd46adb) into master (9090c77) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #4488   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13630     13629    -1     
=========================================
- Hits         13630     13629    -1

Impacted Files	Coverage Δ
fastapi/exceptions.py	`100.00% <100.00%> (ø)`
tests/test_extra_routes.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9090c77...fd46adb. Read the comment docs.

github-actions · 2022-01-27T19:38:29Z

📝 Docs preview for commit b19e848 at: https://61f2f482339a46310dd7a236--fastapi.netlify.app

github-actions · 2022-01-28T17:06:22Z

📝 Docs preview for commit 1b3342b at: https://61f42253a83c1522555c776e--fastapi.netlify.app

github-actions · 2022-01-30T16:18:53Z

📝 Docs preview for commit 09c70c4 at: https://61f6b9f3886122caa7fb096d--fastapi.netlify.app

pyproject.toml

github-actions · 2022-01-31T23:35:32Z

📝 Docs preview for commit 880dd0d at: https://61f8720b27a15533d4fa2da5--fastapi.netlify.app

github-actions · 2022-02-01T14:50:21Z

📝 Docs preview for commit c48a399 at: https://61f94879d85c46e5edab7f8e--fastapi.netlify.app

github-actions · 2022-02-01T23:07:30Z

📝 Docs preview for commit 7b519b8 at: https://61f9bcf8e9ce9131496180ee--fastapi.netlify.app

rabinadk1 · 2022-02-05T07:10:02Z

fastapi/exceptions.py

-        super().__init__(status_code=status_code, detail=detail)
-        self.headers = headers
-
+from starlette.exceptions import HTTPException as HTTPException  # noqa


Is the renaming of import, i.e., as HTTPException needed at the last?

Suggested change

from starlette.exceptions import HTTPException as HTTPException # noqa

from starlette.exceptions import HTTPException

I suppose there's not reason for noqa anymore.

tests/test_extra_routes.py

musicinmybrain · 2022-03-16T13:26:41Z

This works great for me in the Fedora Linux RPM package. However, I still do have to ask pytest to ignore DeprecationWarning, since apparently starlette.middleware.wsgi is going away:

==================================== ERRORS ====================================
______ ERROR collecting tests/test_tutorial/test_wsgi/test_tutorial001.py ______
tests/test_tutorial/test_wsgi/test_tutorial001.py:3: in <module>
    from docs_src.wsgi.tutorial001 import app
docs_src/wsgi/tutorial001.py:2: in <module>
    from fastapi.middleware.wsgi import WSGIMiddleware
../../BUILDROOT/python-fastapi-0.75.0-3.fc37.x86_64/usr/lib/python3.10/site-packages/fastapi/middleware/wsgi.py:1: in <module>
    from starlette.middleware.wsgi import WSGIMiddleware as WSGIMiddleware  # noqa
/usr/lib/python3.10/site-packages/starlette/middleware/wsgi.py:11: in <module>
    warnings.warn(
E   DeprecationWarning: starlette.middleware.wsgi is deprecated and will be removed in a future release. Please refer to https://github.com/abersheeran/a2wsgi as a replacement.
=========================== short test summary info ============================
ERROR tests/test_tutorial/test_wsgi/test_tutorial001.py - DeprecationWarning:...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 2.38s ===============================

Kludex · 2022-03-16T13:27:23Z

I need to update this PR. I'll do it today (I think).

Kludex · 2022-03-16T16:30:36Z

I'm going to just ignore the warning from WSGIMiddleware.

@tiangolo This is the PR that deprecates it: Kludex/starlette#1504

I'm not sure if you want to import a2wsgi on fastapi.middleware.wsgi, and update the docs...

github-actions · 2022-03-16T17:04:19Z

📝 Docs preview for commit d382aa5 at: https://62321787dc48cd00848f8cda--fastapi.netlify.app

musicinmybrain · 2022-03-16T18:28:04Z

Still works for me, including the newly-ignored warning. Thanks!

mdczaplicki · 2022-05-06T13:15:47Z

fastapi/exceptions.py

-        super().__init__(status_code=status_code, detail=detail)
-        self.headers = headers
-
+from starlette.exceptions import HTTPException as HTTPException  # noqa


Suggested change

from starlette.exceptions import HTTPException as HTTPException # noqa

from starlette.exceptions import HTTPException

I suppose there's not reason for noqa anymore.

mdczaplicki · 2022-05-06T13:16:46Z

fastapi/routing.py

            value, errors_ = field.validate(response_content, {}, loc=("response",))
        else:
-            value, errors_ = await run_in_threadpool(
+            value, errors_ = await run_in_threadpool(  # type: ignore[misc]


How about adding proper type hints for these names?

tiangolo · 2022-05-09T17:20:47Z

fastapi/exceptions.py

-    def __init__(
-        self,
-        status_code: int,
-        detail: Any = None,


There are several examples and places in the code base that expect detail to be any JSON-able data, not only a string (as is with Starlette).

So, only for this little type hint we still need the custom HTTPException class in FastAPI.

3 years later, I think this was a mistake.

I know it's documented, but it's confusing that it happens.

github-actions · 2022-05-09T17:34:19Z

📝 Docs preview for commit fd46adb at: https://6279506becc1a10283b84487--fastapi.netlify.app

tiangolo · 2022-05-10T01:42:15Z

Thanks for the work @Kludex! 🚀 🎉

This is now available in FastAPI version 0.77.0 🔖

Due to fastapi/fastapi#4488

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>

Kludex added 11 commits January 26, 2022 17:25

Bump starlette from 0.17.1 to 0.18.0

e5c9343

Fix linter

8d10fca

Fix mypy

7331e08

Remove unused Optional import

fb2fdf5

Bump starlette from 0.18.0 to 0.19.0

c096ac6

Add starlette master branch

a96de7f

Undo some changes

cc64170

Add version on egg

03b0d4c

Try with only link

facb6d8

Add starlette back

a659c2b

Remove HTTPException

4305a0c

Add noqa on reimport

b19e848

Empty commit

1b3342b

Kludex mentioned this pull request Jan 28, 2022

Version 0.19.0 Kludex/starlette#1439

Merged

Update pyproject.toml

09c70c4

Kludex commented Jan 31, 2022

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

Update pyproject.toml

880dd0d

Update pyproject.toml

c48a399

Update pyproject.toml

7b519b8

rabinadk1 reviewed Feb 5, 2022

View reviewed changes

paulo-raca mentioned this pull request Mar 2, 2022

Fix test_extra_routes on latest Starlette #4637

Closed

paulo-raca reviewed Mar 2, 2022

View reviewed changes

tests/test_extra_routes.py Show resolved Hide resolved

BilalAlpaslan approved these changes Mar 3, 2022

View reviewed changes

Ignore WSGIMiddleware deprecation warning on tests

d382aa5

Kludex mentioned this pull request Apr 7, 2022

GZIP content length mismatch fix Kludex/starlette#1579

Closed

1 task

mdczaplicki reviewed May 6, 2022

View reviewed changes

ybinnenwegin2ip mentioned this pull request May 6, 2022

Fastapi 0.76.0 fails to start with python 3.9 #4868

Closed

9 tasks

Merge branch 'master' into bump/starlette-0.19.0

42f5e32

tiangolo reviewed May 9, 2022

View reviewed changes

tiangolo added 2 commits May 9, 2022 12:22

🔧 Fix TOML format

b6003a7

♻️ Re-implement FastAPI's own HTTPException accepting a dict detail

fd46adb

tiangolo changed the title ~~Bump starlette from 0.18.0 to 0.19.0~~ ⬆ Upgrade Starlette from 0.18.0 to 0.19.0 May 9, 2022

tiangolo merged commit 86fa3cb into fastapi:master May 9, 2022

johnoppenheimer added a commit to betagouv/euphrosyne-tools-api that referenced this pull request Aug 8, 2022

fix: Add now required content to JSONResponse

83841e9

Due to fastapi/fastapi#4488

JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022

⬆ Upgrade Starlette from 0.18.0 to 0.19.0 (fastapi#4488)

62f2c3a

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>

papb mentioned this pull request Sep 22, 2022

📝 Update HTTPException details in docs/en/docs/tutorial/handling-errors.md #5418

Merged

Kludex deleted the bump/starlette-0.19.0 branch January 7, 2025 14:41

	from starlette.exceptions import HTTPException as HTTPException # noqa
	from starlette.exceptions import HTTPException

Uh oh!

Conversation

Kludex commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 27, 2022

Uh oh!

github-actions bot commented Jan 28, 2022

Uh oh!

github-actions bot commented Jan 30, 2022

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2022

Uh oh!

github-actions bot commented Feb 1, 2022

Uh oh!

github-actions bot commented Feb 1, 2022

Uh oh!

rabinadk1 Feb 5, 2022

Choose a reason for hiding this comment

Uh oh!

mdczaplicki May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

musicinmybrain commented Mar 16, 2022

Uh oh!

Kludex commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kludex commented Mar 16, 2022

Uh oh!

github-actions bot commented Mar 16, 2022

Uh oh!

musicinmybrain commented Mar 16, 2022

Uh oh!

mdczaplicki May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdczaplicki May 6, 2022

Choose a reason for hiding this comment

Uh oh!

tiangolo May 9, 2022

Choose a reason for hiding this comment

Uh oh!

Kludex Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 9, 2022

Uh oh!

tiangolo commented May 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Kludex commented Jan 27, 2022 •

edited

Loading

codecov bot commented Jan 27, 2022 •

edited

Loading

mdczaplicki May 6, 2022 •

edited

Loading

Kludex commented Mar 16, 2022 •

edited

Loading

mdczaplicki May 6, 2022 •

edited

Loading