Add headers parameter to HTTPException#1435
Merged
Conversation
Contributor
|
Seems pretty reasonable to me yeah. |
Contributor
|
Needs a lil' docs update on https://www.starlette.io/exceptions/ - then I think it's ready to go. |
adriangb
approved these changes
Jan 26, 2022
Contributor
adriangb
left a comment
adriangb
left a comment
There was a problem hiding this comment.
This looks great! We should just test it against FastAPI first to at least know if it will be breaking for them. I don't think it will be.
Contributor
Well I tried, a bunch of other things are broken. But just eyeballing the change, I don't see how it would break FastAPI. So I think we're good to go on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea from @adriangb : #1434 (comment)
The PR #1434 created a use-case for
HTTPException.headers. FastAPI already makes use of this, as mentioned by Adrian on https://github.com/tiangolo/fastapi/blob/291180bf2d8c39e84860c2426b1d58b6c80f6fef/fastapi/exceptions.py#L13 .PR open for discussion. :)