fix: Wait for secrets come down sync #1602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow on some servers we wait forever for the keys while they are not detected in the sync. I think this has something to do with how different server handle uri encoding. However, this should make it more stable.
|
Haven't seen that TD fixed it already at #1584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow on some servers
we wait forever for the keys
while they are not detected
in the sync. I think this has
something to do with how
different server handle uri
encoding. However, this should
make it more stable.
Other things I tried: Put the key we are waiting for in Uri.encodeComponent() or wait on both encoded and not encoded. Found no better solution to this :-(