fix: validate account_data values instead of checking them in syncUpdates #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techno-disaster
force-pushed
the
td/fixAwaitSecrets
branch
from
5986d49 to
1bac5b9
Compare
techno-disaster
force-pushed
the
td/fixAwaitSecrets
branch
from
1bac5b9 to
6fb6165
Compare
techno-disaster
force-pushed
the
td/fixAwaitSecrets
branch
from
6fb6165 to
200c9a5
Compare
krille-chan
previously approved these changes
Nov 7, 2023
techno-disaster
force-pushed
the
td/fixAwaitSecrets
branch
from
200c9a5 to
6697b91
Compare
techno-disaster
force-pushed
the
td/fixAwaitSecrets
branch
from
6697b91 to
9ba5952
Compare
nico-famedly
reviewed
Nov 8, 2023
techno-disaster
force-pushed
the
td/fixAwaitSecrets
branch
from
9ba5952 to
6ced30c
Compare
td-famedly
force-pushed
the
td/fixAwaitSecrets
branch
2 times, most recently
from
cf5d694 to
3a06b38
Compare
td-famedly
changed the title
td-famedly
force-pushed
the
td/fixAwaitSecrets
branch
2 times, most recently
from
bb781c3 to
598d06d
Compare
td-famedly
force-pushed
the
td/fixAwaitSecrets
branch
from
598d06d to
3cbd8b1
Compare
td-famedly
force-pushed
the
td/fixAwaitSecrets
branch
3 times, most recently
from
49fc328 to
8a64a7a
Compare
nico-famedly
approved these changes
Dec 20, 2023
td-famedly
force-pushed
the
td/fixAwaitSecrets
branch
from
8a64a7a to
6b603ed
Compare
|
brb something broke :p |
td-famedly
force-pushed
the
td/fixAwaitSecrets
branch
from
6b603ed to
dc411c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/famedly/product-management/issues/1401
fixes race where sometimes you miss the secrets in sync
edit from product: this also closes #1584