Skip to content

Refactor FBX save functions to use FileSaveOptions#828

Closed
yutingye wants to merge 3 commits intomainfrom
export-D86883821
Closed

Refactor FBX save functions to use FileSaveOptions#828
yutingye wants to merge 3 commits intomainfrom
export-D86883821

Conversation

@yutingye
Copy link
Copy Markdown
Contributor

@yutingye yutingye commented Nov 15, 2025

Summary: This diff refactors the FBX save functions to use the FileSaveOptions struct instead of individual parameters, following the pattern established in D86039901 for GLTF save functions.

Differential Revision: D86883821

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 15, 2025
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Nov 15, 2025

@yutingye has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86883821.

facebook-github-bot pushed a commit that referenced this pull request Nov 15, 2025
@yutingye @facebook-github-bot
Refactor FBX save functions to use FileSaveOptions (#828)
9a34495 
Summary:

This diff refactors the FBX save functions to use the `FileSaveOptions` struct instead of individual parameters, following the pattern established in D86039901 for GLTF save functions.

Differential Revision: D86883821
facebook-github-bot pushed a commit that referenced this pull request Nov 15, 2025
@yutingye @facebook-github-bot
Refactor FBX save functions to use FileSaveOptions (#828)
2ef6f3a 
Summary:

This diff refactors the FBX save functions to use the `FileSaveOptions` struct instead of individual parameters, following the pattern established in D86039901 for GLTF save functions.

Differential Revision: D86883821
facebook-github-bot pushed a commit that referenced this pull request Nov 15, 2025
@yutingye @facebook-github-bot
Refactor FBX save functions to use FileSaveOptions (#828)
9349baf 
Summary:

This diff refactors the FBX save functions to use the `FileSaveOptions` struct instead of individual parameters, following the pattern established in D86039901 for GLTF save functions.

Differential Revision: D86883821
@yutingye @facebook-github-bot
Add parameterized constructor for FileSaveOptions Python binding (#825)
8940d72 
Summary:

This change adds a parameterized constructor to the FileSaveOptions Python binding, enabling users to initialize all member variables directly when creating the object instead of having to set them one by one after construction.

This improves the API ergonomics by allowing cleaner initialization patterns:
```python
options = FileSaveOptions(mesh=False, locators=True, blend_shapes=False)
```

Reviewed By: cstollmeta, jeongseok-meta

Differential Revision: D86904749
@yutingye @facebook-github-bot
Replace GltfOptions with FileSaveOptions in saveGltfCharacter APIs (#826
77c5b77 
)

Summary:

This diff replaces the `GltfOptions` parameter with `FileSaveOptions` in the `saveGltfCharacter` function signatures to provide a unified interface for file saving options across different formats (GLTF and FBX).

Reviewed By: cstollmeta, jeongseok-meta

Differential Revision: D86882964
@yutingye @facebook-github-bot
Refactor FBX save functions to use FileSaveOptions (#828)
896599a 
Summary:

This diff refactors the FBX save functions to use the `FileSaveOptions` struct instead of individual parameters, following the pattern established in D86039901 for GLTF save functions.

Differential Revision: D86883821
facebook-github-bot pushed a commit that referenced this pull request Nov 15, 2025
@yutingye @facebook-github-bot
Refactor FBX save functions to use FileSaveOptions (#828)
185ff4d 
Summary:

This diff refactors the FBX save functions to use the `FileSaveOptions` struct instead of individual parameters, following the pattern established in D86039901 for GLTF save functions.

Differential Revision: D86883821
facebook-github-bot pushed a commit that referenced this pull request Nov 16, 2025
@yutingye @facebook-github-bot
Refactor FBX save functions to use FileSaveOptions (#828)
34c06d4 
Summary:

This diff refactors the FBX save functions to use the `FileSaveOptions` struct instead of individual parameters, following the pattern established in D86039901 for GLTF save functions.

Reviewed By: jeongseok-meta

Differential Revision: D86883821
facebook-github-bot pushed a commit that referenced this pull request Nov 16, 2025
@yutingye @facebook-github-bot
Refactor FBX save functions to use FileSaveOptions (#828)
74b63d3 
Summary:

This diff refactors the FBX save functions to use the `FileSaveOptions` struct instead of individual parameters, following the pattern established in D86039901 for GLTF save functions.

Reviewed By: jeongseok-meta

Differential Revision: D86883821
@meta-codesync meta-codesync Bot closed this in b235197 Nov 16, 2025
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Nov 16, 2025

This pull request has been merged in b235197.

@jeongseok-meta jeongseok-meta deleted the export-D86883821 branch November 16, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yutingye @facebook-github-bot