Replace GltfOptions with FileSaveOptions in saveGltfCharacter APIs#826
Closed
yutingye wants to merge 2 commits into
Closed
Replace GltfOptions with FileSaveOptions in saveGltfCharacter APIs#826yutingye wants to merge 2 commits into
yutingye wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
facebook-github-bot
force-pushed
the
export-D86882964
branch
from
af405af to
9e6dad8
Compare
Summary: This change adds a parameterized constructor to the FileSaveOptions Python binding, enabling users to initialize all member variables directly when creating the object instead of having to set them one by one after construction. This improves the API ergonomics by allowing cleaner initialization patterns: ```python options = FileSaveOptions(mesh=False, locators=True, blend_shapes=False) ``` Reviewed By: cstollmeta, jeongseok-meta Differential Revision: D86904749
facebook-github-bot
force-pushed
the
export-D86882964
branch
from
9e6dad8 to
3c270a3
Compare
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
Contributor
|
This pull request has been merged in 6934fbf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This diff replaces the
GltfOptionsparameter withFileSaveOptionsin thesaveGltfCharacterfunction signatures to provide a unified interface for file saving options across different formats (GLTF and FBX).Reviewed By: cstollmeta, jeongseok-meta
Differential Revision: D86882964