Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Within" set query util #1819

Merged
merged 9 commits into from
Feb 22, 2024
Merged

"Within" set query util #1819

merged 9 commits into from
Feb 22, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Feb 22, 2024 •
edited
Loading

Motivation and Context

Based on #1770.

Adds "within" preposition query based on raycasting from object keypoints.

NOTE: returns a set of object_id rather than previous prototype's ManagedObject tuples.

How Has This Been Tested

Added a pytest

Types of changes

  • [Development] A pull request that add new features to the habitat-lab task and environment codebase. Development Pull Requests must be small (less that 500 lines of code change), have unit testing, very extensive documentation and examples. These are typically new tasks, environments, sensors, etc... The review process for these Pull Request is longer because these changes will be maintained by our core team of developers, so make sure your changes are easy to understand!

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 22, 2024
jacobkrantz
jacobkrantz approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@jacobkrantz jacobkrantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Can merge after #1817

@aclegg3 aclegg3 merged commit 5c3d8de into main Feb 22, 2024
1 of 3 checks passed
@aclegg3 aclegg3 deleted the prepositional-logic-for-eval-3 branch February 22, 2024 23:42
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@aclegg3
"Within" set query util (facebookresearch#1819)
1da00d2 
* add "within" query util and test
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@aclegg3
"Within" set query util (facebookresearch#1819)
f3b1675 
* add "within" query util and test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobkrantz jacobkrantz jacobkrantz approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@xavierpuigf xavierpuigf Awaiting requested review from xavierpuigf

@rutadesai rutadesai Awaiting requested review from rutadesai

@ASzot ASzot Awaiting requested review from ASzot

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @jacobkrantz @facebook-github-bot