"Above" set query util #1817
Merged
"Above" set query util #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jacobkrantz
approved these changes
Feb 22, 2024
| all_objects = get_all_object_ids(sim) | ||
|
|
||
| mixer_object = get_obj_from_handle( | ||
| sim, "frl_apartment_small_appliance_01_:0000" |
There was a problem hiding this comment.
Are these sim entities stable enough to be included in tests, or should we be placing new entities?
There was a problem hiding this comment.
I'm assuming these are stable because they are ReplicaCAD scenes which we have no intention of modifying. This scene "apt_0" is a reconstruction of the first static "FRL apartment" arrangement from Replica.
If anything were to change in the future it would most likely be dynamic settling which should preserve the tested relationships here.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* add above set query util * add tests for above and general purpose object_keypoint_cast
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* add above set query util * add tests for above and general purpose object_keypoint_cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Based on #1770.
Adds "above" preposition query based on raycasting from object keypoints.
NOTE: returns a set of object_id rather than previous prototype's ManagedObject tuples.
How Has This Been Tested
Added pytests for keypoint casting and "above".
Types of changes
Checklist