Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correction2 of type-cast when self._hitl_config.episodes_filter==None #1780

Merged
merged 1 commit into from
Jan 30, 2024
Merged

correction2 of type-cast when self._hitl_config.episodes_filter==None #1780

merged 1 commit into from
Jan 30, 2024

Conversation

henrysamer
Copy link
Contributor

Motivation and Context

Correction of redundant type cast when self._hitl_config.episodes_filter==None

How Has This Been Tested

tested locally

Types of changes

  • [Bug Fix] Omitted redundant type cast

Checklist

  • [ x] My code follows the code style of this project.
  • [ x] I have updated the documentation if required.
  • [x ] I have read the CONTRIBUTING document.
  • [ x] I have completed my CLA (see CONTRIBUTING)
  • [ x] I have added tests to cover my changes if required.

@henrysamer henrysamer self-assigned this Jan 30, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 30, 2024
eundersander
eundersander approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0mdc 0mdc self-requested a review January 30, 2024 19:17
@0mdc 0mdc mentioned this pull request Jan 30, 2024
Closed
5 tasks
@0mdc 0mdc marked this pull request as ready for review January 30, 2024 19:18
@0mdc 0mdc merged commit fb768ab into main Jan 30, 2024
4 checks passed
@0mdc 0mdc deleted the hitl_fix3 branch January 30, 2024 19:19
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@henrysamer
Fix type-cast when self._hitl_config.episodes_filter==None (facebookr…
282753a 
…esearch#1780)
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@henrysamer
Fix type-cast when self._hitl_config.episodes_filter==None (facebookr…
05cfe27 
…esearch#1780)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eundersander eundersander eundersander approved these changes

@0mdc 0mdc 0mdc approved these changes

Assignees

@henrysamer henrysamer

Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrysamer @eundersander @0mdc @facebook-github-bot