feat(cudf): Add NotFunction, IsNullFunction, IsNotNullFunction#17314
feat(cudf): Add NotFunction, IsNullFunction, IsNotNullFunction#17314mattgara wants to merge 4 commits intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
Build Impact AnalysisFull build recommended. Files outside the dependency graph changed:
These directories are not fully covered by the dependency graph. A full build is the safest option. Slow path • Graph generated from PR branch |
devavret
left a comment
There was a problem hiding this comment.
Small overlap with #16503 but I think @pramodsatya had a different purpose with that, trying to use registry in sidecar.
| registerCudfFunction( | ||
| "not", | ||
| [](const std::string&, const std::shared_ptr<velox::exec::Expr>& expr) { | ||
| return std::make_shared<NotFunction>(expr); | ||
| }, |
There was a problem hiding this comment.
Instead of making a NotFunction, you can make a UnaryFunction and during registration, provide a factory like so:
| registerCudfFunction( | |
| "not", | |
| [](const std::string&, const std::shared_ptr<velox::exec::Expr>& expr) { | |
| return std::make_shared<NotFunction>(expr); | |
| }, | |
| registerCudfFunction( | |
| "not", | |
| [](const std::string&, const std::shared_ptr<velox::exec::Expr>& expr) { | |
| return std::make_shared<UnaryFunction>(expr, cudf::unary_operator::NOT); | |
| }, |
Noted @devavret, closing #16503 in favor of this PR (17314 subsumes 16503 as you pointed out). |
IS NULL,IS NOT NULLandNOTfunctions