feat(cuDF): Support function signature retrieval from registry#16504
Open
pramodsatya wants to merge 2 commits intofacebookincubator:mainfrom
Open
feat(cuDF): Support function signature retrieval from registry#16504pramodsatya wants to merge 2 commits intofacebookincubator:mainfrom
pramodsatya wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
d079afb to
6a891ec
Compare
Collaborator
Author
|
@majetideepak, @devavret, could you please help review this change? |
Build Impact AnalysisFull build recommended. Files outside the dependency graph changed:
These directories are not fully covered by the dependency graph. A full build is the safest option. Fast path • Graph from main@65800681f99ac53fe2cb3d5c121dd8ba611e385b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec::FunctionSignaturemetadata.FunctionSignatureMap/AggregateFunctionSignatureMap, reusing the existing signature builders to preserve type variables, intermediate types, and varargs info.Motivation
Presto’s native sidecar plugin needs to enumerate function signatures to manage cuDF functions, this is achieved via the
/v1/functionsendpoint on the Presto C++ sidecar. This Velox change exposes cuDF functions metadata to Presto via the sidecar, allowing for seamless integration of cuDF functions into Presto. Making the coordinator aware of function signatures supported for cuDF execution enables intelligent execution-aware planning and unlocks fail-fast behavior.