Skip to content

feat(cuDF): Support function signature retrieval from registry#16504

Open
pramodsatya wants to merge 2 commits intofacebookincubator:mainfrom
pramodsatya:cudf_func_reg
Open

feat(cuDF): Support function signature retrieval from registry#16504
pramodsatya wants to merge 2 commits intofacebookincubator:mainfrom
pramodsatya:cudf_func_reg

Conversation

@pramodsatya
Copy link
Copy Markdown
Collaborator

@pramodsatya pramodsatya commented Feb 24, 2026

Summary

  • Expose the cuDF scalar function registry so Velox can surface fully-qualified function names together with their exec::FunctionSignature metadata.
  • Add utilities that convert the cuDF scalar and aggregation registries into FunctionSignatureMap / AggregateFunctionSignatureMap, reusing the existing signature builders to preserve type variables, intermediate types, and varargs info.
  • Make these maps available to higher layers (e.g., Presto native sidecar) so external engines can be made aware of GPU function capabilities.

Motivation

Presto’s native sidecar plugin needs to enumerate function signatures to manage cuDF functions, this is achieved via the /v1/functions endpoint on the Presto C++ sidecar. This Velox change exposes cuDF functions metadata to Presto via the sidecar, allowing for seamless integration of cuDF functions into Presto. Making the coordinator aware of function signatures supported for cuDF execution enables intelligent execution-aware planning and unlocks fail-fast behavior.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 24, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 24, 2026

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a2c39c1
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/69d005240a4f0d0008b5c720

@devavret devavret added the cudf cudf related - GPU acceleration label Mar 12, 2026
@pramodsatya pramodsatya changed the title feat: Support cudf function signature retrieval from registry feat(cuDF): Support function signature retrieval from registry Mar 18, 2026
@pramodsatya pramodsatya marked this pull request as ready for review March 19, 2026 01:12
@pramodsatya
Copy link
Copy Markdown
Collaborator Author

@majetideepak, @devavret, could you please help review this change?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Build Impact Analysis

Full build recommended. Files outside the dependency graph changed:

  • velox/experimental/cudf/exec/CudfHashAggregation.cpp
  • velox/experimental/cudf/exec/CudfHashAggregation.h
  • velox/experimental/cudf/expression/ExpressionEvaluator.cpp
  • velox/experimental/cudf/expression/ExpressionEvaluator.h

These directories are not fully covered by the dependency graph. A full build is the safest option.

cmake --build _build/release

Fast path • Graph from main@65800681f99ac53fe2cb3d5c121dd8ba611e385b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cudf cudf related - GPU acceleration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants