fix(build): Register /usr/local/lib64 with ldconfig after gflags install on CentOS 9 by Avinash-Raj · Pull Request #16817 · facebookincubator/velox

Avinash-Raj · 2026-03-18T10:42:46Z

gflags installs to /usr/local/lib64 which is not in the default ldconfig search path on CentOS Stream 9.
This causes downstream builds (e.g. fbthrift's thrift1 compiler) to fail at runtime with:

error while loading shared libraries: libgflags.so.2.2

This moves gflags to /usr/local/lib to align with other dependency installation paths and registers that path with ldconfig.

netlify · 2026-03-18T10:42:52Z

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	`e4bdbb5`
🔍 Latest deploy log	https://app.netlify.com/projects/meta-velox/deploys/69bde1c75af77e0008e9d1eb

simoneves · 2026-03-18T16:56:01Z

scripts/setup-centos9.sh

  dnf remove -y gflags
  wget_and_untar https://github.com/gflags/gflags/archive/"${GFLAGS_VERSION}".tar.gz gflags
  cmake_install_dir gflags -DBUILD_SHARED_LIBS=ON -DBUILD_STATIC_LIBS=ON -DBUILD_gflags_LIB=ON -DLIB_SUFFIX=64
+  echo "/usr/local/lib64" >/etc/ld.so.conf.d/local-lib64.conf && ldconfig


Nit: space between > and /etc.

Initially I did the same, but the repo's pre-commit hook complains about the space which appears next to the > operator.

I'm not familiar with the contents of /usr/local/lib64/ but could this create conflicts with other libraries that share the same soname?

Have we reviewed if any such conflicts are possible?

These days it seems fairly interchangeable with /usr/local/lib and some libraries just decide to put their DSOs there instead. @bdice made a similar change in the Velox container Dockerfile a few weeks ago (#16387)

What happens if we remove -DLIB_SUFFIX=64 from the above, and then remove this line? I believe that would make it install to /usr/local/lib instead of /usr/local/lib64. That might be cleaner overall.

We can try this.

Validating the changes with a manual CI run using Presto master (2ff4adf2d3b1691947b16bcd7c41b3a87ce0bc9f) and this branch of Velox (a14663eaf90afa42be471907d402f2f8a4b614a4).

https://github.com/rapidsai/velox-testing/actions/runs/23355678278/job/67945747920

I settled on a solution that calls ldconfig but doesn't use -DLIB_SUFFIX=64 anymore.

I accidentally rebased/force-pushed, then restored the history in a second force-push. Apologies for that. I'll approve the PR.

Validating here: https://github.com/rapidsai/velox-testing/actions/runs/23367622629

This worked. Let's get it merged. 👍

scripts/setup-centos9.sh

…stall on CentOS 9 gflags installs shared libraries to INSTALL_PREFIX/lib, which is not in the default ldconfig search path on CentOS Stream 9. This causes fbthrift's thrift1 compiler to fail at runtime with: error while loading shared libraries: libgflags.so.2.2 Also remove -DLIB_SUFFIX=64 so gflags installs to lib/ instead of lib64/, consistent with the INSTALL_PREFIX convention.

aditi-pandit · 2026-03-23T15:38:51Z

I've been seeing this error when starting presto_server which might be related.

/Users/aditipandit/ahana_dev/presto/presto/presto-native-execution/cmake-build-debug/presto_cpp/main/presto_server --logtostderr=1 --v=1 --etc_dir=/Users/aditipandit/ahana_dev/presto/presto/presto-native-execution/etc
ERROR: something wrong with flag 'flagfile' in file '/Users/aditipandit/ahana_dev/presto/presto/presto-native-execution/deps-download/gflags/src/gflags.cc'.  One possibility: file '/Users/aditipandit/ahana_dev/presto/presto/presto-native-execution/deps-download/gflags/src/gflags.cc' is being linked both statically and dynamically into this executable.

Have others seen this as well ?

@majetideepak, @czentgr

majetideepak · 2026-03-23T16:44:24Z

I've been seeing this error when starting presto_server which might be related.

We discussed this internally. Aditi is seeing this issue on MacOS. Christian suggested the following fix

set VELOX_BUILD_SHARED=ON (env var) and then re-install folly via setup script (setup-macos.sh install_folly).
Then build with EXTRA_CMAKE_FLAGS="-DVELOX_BUILD_SHARED=ON" .

meta-codesync · 2026-03-23T16:50:54Z

@kgpai has imported this pull request. If you are a Meta employee, you can view this in D97776866.

bdice · 2026-03-23T16:51:33Z

@aditi-pandit I think this is solving a different issue. We saw this kind of error when building the Presto native dependencies image:

/build/deps-download/fbthrift/_build/bin/thrift1: error while loading shared libraries: libgflags.so.2.2: cannot open shared object file: No such file or directory

Full logs are in https://github.com/rapidsai/velox-testing/actions/runs/23355678278/job/67945776144.

meta-codesync · 2026-03-23T21:47:17Z

@kgpai merged this pull request in 1e19ac6.

Fix gflags shared library not found on CentOS 9

090a85c

Avinash-Raj requested review from assignUser and majetideepak as code owners March 18, 2026 10:42

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2026

Avinash-Raj changed the title ~~Fix: gflags shared library not found on CentOS 9~~ fix(build): Register /usr/local/lib64 with ldconfig after gflags install on CentOS 9 Mar 18, 2026

Avinash-Raj added 2 commits March 18, 2026 11:02

pre-commit formatting fix

6257263

Merge branch 'main' into avi/fix-centos9-gflags-ldconfig

d4b0f94

simoneves suggested changes Mar 18, 2026

View reviewed changes

majetideepak approved these changes Mar 18, 2026

View reviewed changes

Merge branch 'main' into avi/fix-centos9-gflags-ldconfig

b4f4572

simoneves approved these changes Mar 19, 2026

View reviewed changes

Merge branch 'main' into avi/fix-centos9-gflags-ldconfig

d3a235b

bdice reviewed Mar 20, 2026

View reviewed changes

scripts/setup-centos9.sh Outdated Show resolved Hide resolved

Remove -DLIB_SUFFIX=64

8e2e716

bdice reviewed Mar 20, 2026

View reviewed changes

scripts/setup-centos9.sh Outdated Show resolved Hide resolved

bdice added 2 commits March 20, 2026 12:50

Fix spacing

36c3a4c

Merge branch 'main' into avi/fix-centos9-gflags-ldconfig

a14663e

bdice force-pushed the avi/fix-centos9-gflags-ldconfig branch from a14663e to cc68f01 Compare March 20, 2026 23:04

bdice force-pushed the avi/fix-centos9-gflags-ldconfig branch from cc68f01 to e4bdbb5 Compare March 21, 2026 00:09

bdice approved these changes Mar 21, 2026

View reviewed changes

bdice added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Mar 23, 2026

majetideepak approved these changes Mar 23, 2026

View reviewed changes

meta-codesync bot closed this in 1e19ac6 Mar 23, 2026

facebook-github-tools bot added the Merged label Mar 23, 2026

Conversation

Avinash-Raj commented Mar 18, 2026 • edited by bdice Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for meta-velox canceled.

Uh oh!

simoneves Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Avinash-Raj Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattgara Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simoneves Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

bdice Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

majetideepak Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

bdice Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bdice Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

bdice Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

bdice Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aditi-pandit commented Mar 23, 2026

Uh oh!

majetideepak commented Mar 23, 2026

Uh oh!

meta-codesync bot commented Mar 23, 2026

Uh oh!

bdice commented Mar 23, 2026

Uh oh!

meta-codesync bot commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Avinash-Raj commented Mar 18, 2026 •

edited by bdice

Loading

netlify bot commented Mar 18, 2026 •

edited

Loading

Avinash-Raj Mar 18, 2026 •

edited

Loading

mattgara Mar 18, 2026 •

edited

Loading

bdice Mar 20, 2026 •

edited

Loading