fix(docker): Fix buildx warnings breaking multi-arch manifest merge#16387
Closed
bdice wants to merge 3 commits intofacebookincubator:mainfrom
Closed
fix(docker): Fix buildx warnings breaking multi-arch manifest merge#16387bdice wants to merge 3 commits intofacebookincubator:mainfrom
bdice wants to merge 3 commits intofacebookincubator:mainfrom
Conversation
The Export digests jq filter iterated all top-level bake metadata keys, including buildx.build.warnings, creating a spurious digest file. The merge job then failed trying to create a manifest for it. Filter to only entries with image.name (real image targets) and fix the undefined LD_LIBRARY_PATH variable that triggered the warning.
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
kgpai
approved these changes
Feb 20, 2026
kgpai
added
the
ready-to-merge
Use /etc/ld.so.conf.d/velox_deps.conf and ldconfig instead of setting LD_LIBRARY_PATH in the pyvelox and adapters stages. This eliminates the buildx warning caused by undefined $LD_LIBRARY_PATH and follows the standard mechanism for registering shared library paths in containers. In the adapters stage, move COPY --from=adapters-build before the ldconfig RUN so the libraries are on disk when the cache is built. Closes facebookincubator#16386
karthikeyann
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issues discussed in #16234.
The "Export digests" jq filter processes all top-level bake metadata keys, including non-image keys like
buildx.build.warnings. The merge job then fails trying to create a manifest for them. Filter to only entries withimage.name(real image targets), and fix the undefined$LD_LIBRARY_PATHthat triggers the warning.Analysis: #16234 (comment) and #16234 (comment)
I implemented the proposal in #16386 with
ldconfig. Closes #16386.