Skip to content

fix(build): Add c-ares installation to Mac setup #16250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nmahadevuni wants to merge 1 commit into from
Closed

fix(build): Add c-ares installation to Mac setup #16250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/setup-macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export CMAKE_POLICY_VERSION_MINIMUM="3.5"
DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)}
# gflags and glog are installed from source to ensure version compatibility.
# Homebrew's glog 0.7.x has breaking API changes that are incompatible with folly.
MACOS_VELOX_DEPS="bison flex googletest icu4c libevent libsodium lz4 openssl protobuf@21 simdjson snappy xz xxhash zstd"
MACOS_VELOX_DEPS="bison c-ares flex googletest icu4c libevent libsodium lz4 openssl protobuf@21 simdjson snappy xz xxhash zstd"
Copy link
Copy Markdown
Collaborator

@majetideepak majetideepak Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this go on the Presto side?

MACOS_BUILD_DEPS="ninja cmake"

SUDO="${SUDO:-""}"
Expand Down
Loading