fix(build): Add c-ares installation to Mac setup#16250
Closed
nmahadevuni wants to merge 1 commit intofacebookincubator:mainfrom
Closed
fix(build): Add c-ares installation to Mac setup#16250nmahadevuni wants to merge 1 commit intofacebookincubator:mainfrom
nmahadevuni wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
czentgr
reviewed
Feb 5, 2026
scripts/setup-macos.sh
Outdated
| @@ -43,7 +43,7 @@ export CMAKE_POLICY_VERSION_MINIMUM="3.5" | |||
| DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)} | |||
| # gflags and glog are installed from source to ensure version compatibility. | |||
| # Homebrew's glog 0.7.x has breaking API changes that are incompatible with folly. | |||
| MACOS_VELOX_DEPS="bison flex googletest icu4c libevent libsodium lz4 openssl protobuf@21 simdjson snappy xz xxhash zstd" | |||
| MACOS_VELOX_DEPS="bison flex googletest icu4c libevent libsodium lz4 openssl protobuf@21 simdjson snappy xz xxhash zstd c-ares" | |||
Collaborator
There was a problem hiding this comment.
Please out it in alphabetic order into the list. It is not quite alphabetic but almost.
nmahadevuni
force-pushed
the
add_c-ares_to_mac_setup
branch
from
e7fc23b to
ce26aae
Compare
Collaborator
|
@nmahadevuni Please rebase. The pre-commit should have been fixed. |
nmahadevuni
force-pushed
the
add_c-ares_to_mac_setup
branch
from
ce26aae to
aafb854
Compare
czentgr
approved these changes
Feb 10, 2026
Collaborator
czentgr
left a comment
czentgr
left a comment
There was a problem hiding this comment.
@majetideepak when you get a chance please review too.
We should be ok with using c-ares from brew. On Linux we use the OS version. If needed we can pin it to a specific version but if we keep up with FBOS more or less lets hope we don't have the same issue like we had with other deps that required pinning.
| # gflags and glog are installed from source to ensure version compatibility. | ||
| # Homebrew's glog 0.7.x has breaking API changes that are incompatible with folly. | ||
| MACOS_VELOX_DEPS="bison flex googletest icu4c libevent libsodium lz4 openssl protobuf@21 simdjson snappy xz xxhash zstd" | ||
| MACOS_VELOX_DEPS="bison c-ares flex googletest icu4c libevent libsodium lz4 openssl protobuf@21 simdjson snappy xz xxhash zstd" |
Collaborator
There was a problem hiding this comment.
Shouldn't this go on the Presto side?
Collaborator
|
Moved here prestodb/presto#27135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c-ares is required by proxygen most probably due to the recent FB_OS_VERSION upgrade. Was missing from Mac setup script.