perf: Add rowVectorToIOBufBatch for batch serializing rowVector in RemoteFunction#15718
Closed
avinaashgupta wants to merge 1 commit intomainfrom
Closed
perf: Add rowVectorToIOBufBatch for batch serializing rowVector in RemoteFunction#15718avinaashgupta wants to merge 1 commit intomainfrom
avinaashgupta wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
|
@avinaashgupta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88652511. |
meta-cla
bot
added
the
CLA Signed
…moteFunction (#15718) Summary: Add a new `rowVectorToIOBufBatch` function that uses `BatchVectorSerializer` instead of `IterativeVectorSerializer` for serializing RowVectors to IOBuf. BatchVectorSerializer preserves encodings of input vectors, which is more efficient for serializing a single RowVector (as is the case in remote function calls). This change updates the remote function client and server to use the new batch serialization function while leaving the existing `rowVectorToIOBuf` unchanged, ensuring no impact on other callers. Reviewed By: zation99 Differential Revision: D88652511
facebook-github-bot
force-pushed
the
export-D88652511
branch
from
26b8263 to
cbb03e2
Compare
|
This pull request has been merged in ed2e32a. |
Collaborator
|
Hi @avinaashgupta : Some of the remote functions tests viz https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/TestPrestoContainerRemoteFunction.java#L43 We are validating the tests again with #15712, but have you'll seen such crashes as well internally and can you give some more insight. Created prestodb/presto#26818 @amitkdutta Please triage. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new
rowVectorToIOBufBatchfunction that usesBatchVectorSerializerinstead of
IterativeVectorSerializerfor serializing RowVectors to IOBuf.BatchVectorSerializer preserves encodings of input vectors, which is more
efficient for serializing a single RowVector (as is the case in remote
function calls).
This change updates the remote function client and server to use the new
batch serialization function while leaving the existing
rowVectorToIOBufunchanged, ensuring no impact on other callers.
Differential Revision: D88652511