Fix crash when serializing RowVectors with null children#15712
Closed
avinaashgupta wants to merge 1 commit intomainfrom
Closed
Fix crash when serializing RowVectors with null children#15712avinaashgupta wants to merge 1 commit intomainfrom
avinaashgupta wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@avinaashgupta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88493291. |
Summary: The batch serializer introduced in D87873415 crashes when serializing RowVectors with null children. Null children can exists in RowVector, but the Presto wire format does not support them. This diff fixes the crash by recursively materializing null children as null constant vectors before serialization. The issue was reported by a team (stack trace in P2067237549) where nested RowVectors with nullptr children caused a SIGSEGV in VectorStream::flush(). This fix: - Adds materializeNullChildrenRecursive() helper that recursively traverses RowVectors and replaces nullptr children with BaseVector::createNullConstant() - Updates rowVectorToIOBuf() to call materialization before serialization - Handles null children at all nesting levels - Maintains compatibility with Presto deserialization Differential Revision: D88493291
facebook-github-bot
force-pushed
the
export-D88493291
branch
from
830ad95 to
1c518b3
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The batch serializer introduced in D87873415 crashes when serializing RowVectors with null children. Null children can exists in RowVector, but the Presto wire format does not support them. This diff fixes the crash by recursively materializing null children as null constant vectors before serialization.
The issue was reported by a team (stack trace in P2067237549) where nested RowVectors with nullptr children caused a SIGSEGV in VectorStream::flush().
This fix:
Differential Revision: D88493291