Skip to content

fix(s3fs): Add retries to Minio server start if ports are unavailable #15345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(s3fs): Add retries to Minio server start if ports are unavailable #15345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 42 additions & 20 deletions velox/connectors/hive/storage_adapters/s3fs/tests/MinioServer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,14 @@ namespace {
constexpr char const* kMinioExecutableName{"minio-2022-05-26"};
constexpr char const* kMinioAccessKey{"minio"};
constexpr char const* kMinioSecretKey{"miniopass"};
constexpr char const* kHostAddressTemplate{"127.0.0.1:{}"};
} // namespace

// A minio server, managed as a child process.
// Adapted from the Apache Arrow library.
class MinioServer {
public:
MinioServer() : tempPath_(::exec::test::TempDirectoryPath::create()) {
constexpr auto kHostAddressTemplate = "127.0.0.1:{}";
auto ports = facebook::velox::exec::test::getFreePorts(2);
connectionString_ = fmt::format(kHostAddressTemplate, ports[0]);
consoleAddress_ = fmt::format(kHostAddressTemplate, ports[1]);
}
MinioServer() : tempPath_(::exec::test::TempDirectoryPath::create()) {}

void start();

Expand Down Expand Up @@ -93,21 +89,47 @@ void MinioServer::start() {
}

const auto path = tempPath_->getPath();
try {
serverProcess_ = std::make_shared<boost::process::child>(
env,
exePath,
"server",
"--quiet",
"--compat",
"--address",
connectionString_,
"--console-address",
consoleAddress_,
path.c_str());
} catch (const std::exception& e) {
VELOX_FAIL("Failed to launch Minio server: {}", e.what());
std::vector<int> ports = {9000, 65203};
Copy link
Collaborator

@JkSelf JkSelf Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initialization here seems unnecessary since the value will be overridden when getting the free ports.

int kMaxRetryCount = 5;
Copy link
Collaborator

@JkSelf JkSelf Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: constexpr auto kMaxRetryCount = 5;

int retries = 0;
while (retries++ < kMaxRetryCount) {
try {
// Create a stream to capture process output.
boost::process::ipstream out_stream;
Copy link
Collaborator

@JkSelf JkSelf Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: out_stream -> outStream

ports = facebook::velox::exec::test::getFreePorts(2);
connectionString_ = fmt::format(kHostAddressTemplate, ports[0]);
consoleAddress_ = fmt::format(kHostAddressTemplate, ports[1]);
serverProcess_ = std::make_shared<boost::process::child>(
env,
exePath,
"server",
"--quiet",
"--compat",
"--address",
connectionString_,
"--console-address",
consoleAddress_,
path.c_str(),
boost::process::std_out > out_stream);
std::string output;
// Let the process start.
std::this_thread::sleep_for(std::chrono::seconds(1));
if (!serverProcess_->running()) {
std::getline(out_stream, output);
std::string_view kPortUsedError =
"ERROR Unable to start the server: Specified port is already in use";
if (output == kPortUsedError) {
continue;
}
}
return;
} catch (const std::exception& e) {
VELOX_FAIL("Failed to launch Minio server: {}", e.what());
}
}
VELOX_FAIL(
"Failed to launch Minio server after {} retries due to port conflict",
kMaxRetryCount);
}

void MinioServer::stop() {
Expand Down
Loading