fix(s3fs): Add retries to Minio server start if ports are unavailable #15345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
majetideepak
force-pushed
the
add-s3-minio-retry
branch
from
06f38fb to
0f4c7ba
Compare
JkSelf
reviewed
Nov 3, 2025
| path.c_str()); | ||
| } catch (const std::exception& e) { | ||
| VELOX_FAIL("Failed to launch Minio server: {}", e.what()); | ||
| std::vector<int> ports = {9000, 65203}; |
Collaborator
There was a problem hiding this comment.
The initialization here seems unnecessary since the value will be overridden when getting the free ports.
JkSelf
reviewed
Nov 3, 2025
| } catch (const std::exception& e) { | ||
| VELOX_FAIL("Failed to launch Minio server: {}", e.what()); | ||
| std::vector<int> ports = {9000, 65203}; | ||
| int kMaxRetryCount = 5; |
Collaborator
There was a problem hiding this comment.
nit: constexpr auto kMaxRetryCount = 5;
JkSelf
reviewed
Nov 3, 2025
| while (retries++ < kMaxRetryCount) { | ||
| try { | ||
| // Create a stream to capture process output. | ||
| boost::process::ipstream out_stream; |
Collaborator
There was a problem hiding this comment.
nit: out_stream -> outStream
JkSelf
reviewed
Nov 3, 2025
Collaborator
JkSelf
left a comment
JkSelf
left a comment
There was a problem hiding this comment.
@majetideepak Thanks for your fix. Leaving some comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small chance that the PortUtil might return available ports, but the ports get taken away before use.
Retry if this is the case.
Add a delay to allow the MinIO server to start. Without this, there is a risk of tests being flaky due to the server
not being available.
Fixes: #15304