Skip to content

fix(ci): Fix memory pool cleanup in exchange operator tests #15344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(ci): Fix memory pool cleanup in exchange operator tests #15344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
badd0bd
fix: Fix memory pool cleanup in exchange operator tests (#15344)
duxiao1212 Nov 3, 2025
21a0f00
Merge branch 'main' into export-D85685549
duxiao1212 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions velox/exec/tests/utils/OperatorTestBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ void OperatorTestBase::SetUp() {
void OperatorTestBase::TearDown() {
waitForAllTasksToBeDeleted();
stopPeriodicStatsReporter();
executor_.reset();
// There might be lingering exchange source on executor even after all tasks
// are deleted. This can cause memory leak because exchange source holds
// reference to memory pool. We need to make sure they are properly cleaned.
Expand Down
4 changes: 2 additions & 2 deletions velox/vector/tests/utils/VectorTestBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,8 +846,8 @@ class VectorTestBase {
memory::memoryManager()->addRootPool()};
std::shared_ptr<memory::MemoryPool> pool_{rootPool_->addLeafChild("leaf")};
velox::test::VectorMaker vectorMaker_{pool_.get()};
std::shared_ptr<folly::Executor> executor_{
std::make_shared<folly::CPUThreadPoolExecutor>(
std::unique_ptr<folly::Executor> executor_{
std::make_unique<folly::CPUThreadPoolExecutor>(
std::thread::hardware_concurrency())};
std::shared_ptr<folly::Executor> spillExecutor_{
std::make_shared<folly::CPUThreadPoolExecutor>(
Expand Down
Loading