fix(ci): Fix memory pool cleanup in exchange operator tests #15344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@duxiao1212 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85685549. |
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Oct 31, 2025
…bator#15344) Summary: X-link: prestodb/presto#26461 Reset executor before test teardown to ensure async work completes and releases memory pool references before SharedArbitrator shutdown checks. The executor thread pool processes async tasks could hold references to leaf memory pools. Without explicitly resetting the executor, these tasks complete after TearDown(), keeping the pool hierarchy alive during shutdown assertions, causing " Unexpected alive participants" errors. Reviewed By: xiaoxmeng Differential Revision: D85685549
duxiao1212
force-pushed
the
export-D85685549
branch
from
36dd50f to
d2b0666
Compare
duxiao1212
changed the title
duxiao1212
changed the title
duxiao1212
force-pushed
the
export-D85685549
branch
from
d2b0666 to
b2fdedf
Compare
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Oct 31, 2025
…bator#15344) Summary: The executor thread pool processes async tasks could hold references to leaf memory pools. Without explicitly resetting the executor, these tasks complete after TearDown(), keeping the pool hierarchy alive during shutdown assertions, causing " Unexpected alive participants" errors. Reset executor before test teardown to ensure async work completes and releases memory pool references before SharedArbitrator shutdown checks. 1: executor_.reset() triggers the destructor 2: CPUThreadPoolExecutor's destructor calls thread join internally 3: This blocks until all queued async work completes 4: Ensures pool references are released before TearDown() Reviewed By: xiaoxmeng Differential Revision: D85685549
xiaoxmeng
approved these changes
Oct 31, 2025
…bator#15344) Summary: The executor thread pool processes async tasks could hold references to leaf memory pools. Without explicitly resetting the executor, these tasks complete after TearDown(), keeping the pool hierarchy alive during shutdown assertions, causing " Unexpected alive participants" errors. Reset executor before test teardown to ensure async work completes and releases memory pool references before SharedArbitrator shutdown checks. 1: executor_.reset() triggers the destructor 2: CPUThreadPoolExecutor's destructor calls thread join internally 3: This blocks until all queued async work completes 4: Ensures pool references are released before TearDown() Reviewed By: xiaoxmeng Differential Revision: D85685549
duxiao1212
force-pushed
the
export-D85685549
branch
from
b2fdedf to
badd0bd
Compare
|
This pull request has been merged in 833482d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reset executor before test teardown to ensure async work completes and releases
memory pool references before SharedArbitrator shutdown checks.
The executor thread pool processes async tasks could hold references to leaf memory pools.
Without explicitly resetting the executor, these tasks complete after TearDown(), keeping the pool hierarchy alive during shutdown assertions, causing " Unexpected alive participants" errors.