Support getMethod without ::javaobject or local_ref in return #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Treat getMethod<JFoo> as equivalent to getMethod<JniType<JFoo>>, which is equivalent to getMethod<JFoo::javaobject>. Update all call sites. Some were calling getMethod<local_ref<JFoo>>, which is equivalent. Test Plan: CI
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@dreiss has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to facebookarchive/profilo
that referenced
this pull request
Oct 28, 2019
Summary: Treat `getMethod<JFoo()>` as equivalent to `getMethod<JniType<JFoo>()>`, which is equivalent to `getMethod<JFoo::javaobject()>`. Update all call sites. Some were calling getMethod<local_ref<JFoo>>, which is equivalent. Pull Request resolved: facebookincubator/fbjni#19 Test Plan: CI Reviewed By: cjhopman Differential Revision: D18121237 Pulled By: dreiss fbshipit-source-id: 2f0b6fc1909599256cdc708e721c9d877492d54d
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Oct 28, 2019
Summary: Treat `getMethod<JFoo()>` as equivalent to `getMethod<JniType<JFoo>()>`, which is equivalent to `getMethod<JFoo::javaobject()>`. Update all call sites. Some were calling getMethod<local_ref<JFoo>>, which is equivalent. Pull Request resolved: facebookincubator/fbjni#19 Test Plan: CI Reviewed By: cjhopman Differential Revision: D18121237 Pulled By: dreiss fbshipit-source-id: 2f0b6fc1909599256cdc708e721c9d877492d54d
EduardoCostaom
pushed a commit
to EduardoCostaom/profilo
that referenced
this pull request
Nov 2, 2022
Summary: Treat `getMethod<JFoo()>` as equivalent to `getMethod<JniType<JFoo>()>`, which is equivalent to `getMethod<JFoo::javaobject()>`. Update all call sites. Some were calling getMethod<local_ref<JFoo>>, which is equivalent. Pull Request resolved: facebookincubator/fbjni#19 Test Plan: CI Reviewed By: cjhopman Differential Revision: D18121237 Pulled By: dreiss fbshipit-source-id: 2f0b6fc1909599256cdc708e721c9d877492d54d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Treat getMethod as equivalent to getMethod<JniType>,
which is equivalent to getMethodJFoo::javaobject.
Update all call sites. Some were calling getMethod<local_ref>,
which is equivalent.
Test Plan:
CI