Fix typo for python package name #19
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@willholen is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@willholen has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks! |
Summary: Treat `getMethod<JFoo()>` as equivalent to `getMethod<JniType<JFoo>()>`, which is equivalent to `getMethod<JFoo::javaobject()>`. Update all call sites. Some were calling getMethod<local_ref<JFoo>>, which is equivalent. Pull Request resolved: facebookincubator/fbjni#19 Test Plan: CI Reviewed By: cjhopman Differential Revision: D18121237 Pulled By: dreiss fbshipit-source-id: 2f0b6fc1909599256cdc708e721c9d877492d54d
No description provided.