This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Disable asserts by default #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HHVM >= 3.12 enables asserts by default, which is what PHP does, but previously it had them disabled by default. When oss-performance runs against Mediawiki target it now fails for HHVM >= 3.12. At the client side we get and "Internal server error": HTTP/1.1 500 hphp_invoke. At the server side we get "Fatal error: assert() is not supported: assert with strings argument in RepoAuthoritative mode in /<tmpdir>/mediawiki- 1.26.2/includes/parser/Preprocessor_Hash.php on line 485". Thus this php.ini param. solves this issue by disabling asserts in repo-auth mode.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
related to facebook/hhvm#6764 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHVM >= 3.12 enables asserts by default, which is what PHP does, but
previously it had them disabled by default. When oss-performance runs
against Mediawiki target it now fails for HHVM >= 3.12. At the client
side we get and "Internal server error": HTTP/1.1 500 hphp_invoke. At
the server side we get "Fatal error: assert() is not supported: assert
with strings argument in RepoAuthoritative mode in //mediawiki-
1.26.2/includes/parser/Preprocessor_Hash.php on line 485". Thus this
php.ini param. solves this issue by disabling asserts in repo-auth mode.