Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asserts active by default in nightlies, incompatible with repo auth #6764

Closed
octmoraru opened this issue Jan 19, 2016 · 3 comments
Closed

Asserts active by default in nightlies, incompatible with repo auth #6764

octmoraru opened this issue Jan 19, 2016 · 3 comments

Comments

@octmoraru
Copy link
Contributor

Commit d7ce713 activates PHP assertions by default. These are not supported in RepoAuthoritative mode.

For this reason. the oss-performance MediaWiki benchmark fails:

Fatal error: assert() is not supported: assert with strings argument in RepoAuthoritative mode in /tmp/hhvm-nginxHMBBMk/mediawiki/includes/parser/Preprocessor_Hash.php on line 492

Line 492 in Preprocessor_Hash.php contains, as expected, an assert() with string arguments:

// A heading must be open, otherwise \n wouldn't have been in the search list
assert( '$piece->open == "\n"' );
$part = $piece->getCurrentPart();
@fredemmott
Copy link
Contributor

cc @paulbiss: I assume there's a way to disable it? Possibly should also disable it by default when building repos/using repo auth mode, but not sure that silent behavior change would be a good thing.

@fredemmott fredemmott changed the title MediaWiki Failure Asserts active by default in nightlies, incompatible with repo auth Jan 19, 2016
@fredemmott
Copy link
Contributor

Also, error should probably either give the appropriate ini settings or link to the documentation.

@octmoraru
Copy link
Contributor Author

Hi. Until this issue is fixed, we'll be running our nightly MediaWiki benchmark with "assertions.active=0" in the INI file: https://lists.01.org/pipermail/langperf/2016-January/000443.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants