This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Update siege blacklist to 3.0 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay; I'm no longer working on HHVM, and have asked for a new internal volunteer to take over this project - if that doesn't happen, I will get to this, but it might take a while. |
|
This already made it to master. |
|
No it didn't? Patch changes 3 to 3.0, and updates the error message... Master hasn't changed in 2 years https://github.com/hhvm/oss-performance/blame/master/base/Siege.php#L31 |
|
Whoops. I think I have patched this locally. |
|
Hahahaah. Thanks! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #50