Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Commit

Permalink
Merge pull request #68 from reedy/reedy-siege-3.0
Browse files Browse the repository at this point in the history 
Update siege blacklist to 3.0
  • Loading branch information
@mofarrell
mofarrell authored Feb 13, 2017
2 parents adb976a + 2927195 commit 0feb383
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions base/Siege.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ public function __construct(
escapeshellarg($options->siege).' --version 2>&1 | head -n 1',
),
);
$bad_prefix = 'SIEGE 3';
$bad_prefix = 'SIEGE 3.0';
if (substr($version_line, 0, strlen($bad_prefix)) === $bad_prefix) {
fprintf(
STDERR,
"WARNING: Siege 3.0.0-3.0.7 sends an incorrect HOST header to ports ".
"other than :80 and :443. Siege 3.0.8 and 3.0.9 sometimes sends full ".
"URLs as paths. You are using '%s'.\n\n".
"You can specify a path to siege 2.7x with the ".
"You can specify a path to siege 2.7x or > 3.1 with the ".
"--siege=/path/to/siege option. If you have patched siege to fix ".
"these issues, pass --skip-version-checks.\n",
$version_line,
Expand Down

4 comments on commit 0feb383

@mofarrell
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try 3.1.2. I may have seen issues in 3.1.0 (if so we can black list it).
A side note: I am in the process of getting siege 4.0.3rc3 working. Siege 4 introduces parsing of html, and fetching resources, which breaks some frameworks, and changes the testing urls. These can be explicitly disabled from the CLI starting in 4.0.3.

@mofarrell
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What system are you running on? An ubuntu system? Also what framework are you testing?

I am running on ubuntu 16.04 with siege 3.1.2 (now) and hhvm 3.18.0, running wordpress, and mediawiki targets cleanly.

@mofarrell
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a setup running centos 7. Siege 3.1.0 (and siege 4.0.3rc3 with a patch to disable the parser). I do have issues with mediawiki atm, but wordpress, and drupal7 seem to work (I haven't tried the others).

Does the failure only happen on the benchmarking run? Or is it also failing the multirequest warmup, and single request warmup?

@mofarrell
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mediawiki is working now as well after fixing some settings.

Please sign in to comment.