-
Notifications
You must be signed in to change notification settings - Fork 45
Conversation
7ad6004
to
ce71ab3
Compare
I will note straight off that is untested, unfortunately. The documentation is a little lacking; should I be able to get away with installing all the "requirements" (on any linux-y OS?), and then the script do the rest? It looks like, to test it on Ubuntu I'd need 12.04 to get siege 2. Debian would need old-stable... Seem a bit old to be properly representative? I'll have a look at popping a CentOS 6 vm, and see how far I get. Maybe getting a one liner install command for people at the same time |
At this point I gave up, for now. Gotta then build hhvm, or use some random persons hhvm repo? |
Nope, can't get any further
https://github.com/facebook/hhvm/wiki/Prebuilt-Packages-on-Ubuntu-12.04 says to install boost 1.49 So we'd need to look at the old version https://github.com/facebook/hhvm/wiki/Building-and-installing-HHVM-on-Ubuntu-12.04/_compare/4b3d35bef1cb494408a4d5ef0eaeca44f5adf270...d8aeff00ca508eb8f5996bc565185e686b08615b But those old libboost1.49 packages don't exist anymore |
It's annoying you can't just run it as root...
bump them further...
Ah, it's in your nginx conf. PR made in #62 Now getting stuck at
Both !$this->options->filecache and file_exists($staticContent) are false |
So it seems Utils::RunCommand($args); isn't creating the file-cache dir? |
If we manually run the command it's building and trying to run...
|
Looks like 1GB ram wasn't enough. Bumped the VM to 3GB
String quoting bug or something?
|
So, now we don't use proxygen, and decide we're not benchmarking either...
|
Ok, so now I have everything running with MW 1.24
The only live hack to my git repo is #62 I'll test this PR after I've had some sleep |
Fixed one minor issue already...
Filed https://phabricator.wikimedia.org/T119818 upstream about the stat issues (not sure if we can do anything about them easily) For some reason, this branch (only this commit ahead of master here) doesn't want to play ball completely... Something doesn't look to be running
|
I guess that's why it's failing to open... |
Ah, it seems to be an issue with the vendor repo...
Which seems to be facebook/hhvm#5834 and as such facebook/hhvm#5833 facebook/hhvm#5834 (comment) does fix it... |
Upstream fix for that HHVM bug is https://gerrit.wikimedia.org/r/#/c/255917/ if we merge it, we'll backport to REL1_25 and REL1_26 With that included in my tarball, MW 1.26 now works fine
|
So, the last thing for me to fix is how I modify that one interface_exists() line. I don't really want to modify the tarball, it just feels icky. Is getting the includes/debug/logger/LoggerFactory.php file after un-tarring, str_replace and putting it back again suitable? Oh, and I want to variablise/constant-ise 'mediawiki-1.26.0', but that's minor and I'll do that on my next revision.... |
This is ready to go now! |
And will be part of the 1.26.1 release https://gerrit.wikimedia.org/r/#/c/255964/ |
Sorry for the delay; we're focused on updating the docs site at the moment, and this will take a fair bit of time to test (and re-run). I should get to it in the next week or two. |
1.26.1 is out now. So I will get the shipped tarball updated to 1.26.1 tomorrow, and then can strip out 10 lines of code for the hhvm repo-authorative mode workaround as that's included |
:like: hopefully I'll get to this monday-wednesday next week - I forgot that 'the next week or two' was while i'm on-call, sorry :( |
Looks like we had a silly bug in 1.26.1 that should be getting a quick release. Will get this updated with 1.26.2 when the tarball is out I don't think the bug is a blocker for running this, as it's mostly on special pages, but might aswell have a known good tarball in it |
4c4a90f
to
58e22c3
Compare
@fredemmott hopefully ready to go now! :) |
Can you re-test this?
When I fix that:
|
Missing ; is just fail on my part. Sorry Looks like that actual error is from https://phabricator.wikimedia.org/T48998 / https://gerrit.wikimedia.org/r/#/c/259940/ from the security update wikimedia/mediawiki@ce2b3c8 and wikimedia/mediawiki@3611c52
to
should fix that Will have to setup my testing environment again get back to you :) |
* Use pristine MediaWiki tarball, copy in LocalSettings.php. * Remove $wgDisableCounters = true;, code was removed from MW core. * Remove patch to include LCStoreStaticArray, in MW Core as of 1.26. * Don't live hack LocalisationCache.php to use $storeClass. = 'LCStoreStaticArray';, just set it in LocalSettings.php. * Update MySQL patch file.
Works fine with the 2 changes as above :)
|
= 'LCStoreStaticArray';, just set it in LocalSettings.php.
Fixes #56