hhvm-repo-mode cannot stat some files from MediaWiki 1.25.1 #5834
Comments
|
I am also seeing a similar sort of message for MediaWiki v1.25.1, although for a small set of file names.
The error message in my case: Forgive me for asking my own questions on someone else's thread, but I did not want to open an issue for the same problem. Appreciate any inputs. |
|
I believe it stats them because some code path somewhere in the source code has included them, it may even be a code path that is guarded by a constant that would normally prevent its inclusion, however, because that code path exists, HHVM attempts to include it in the generated hhbc file. Unless there is a safety mechanism in HHVM that kicks in to disable some optimizations, then, as long as these files aren't being included in an active code path, they shouldn't effect the performance of the generated hhbc file, provided the server is being run in repo-auth mode. Edit: |
|
Is this a stock MediaWiki installation? Does anything in your source code reference those files? I think what @Orvid says is basically correct. |
|
Also worth noting that |
|
As mentioned in my previous comment, none of the files actually exist.
I think HHVM should not read/parse the static files as I am inclined to believe, even without any knowledge about how hhvm works, that static files are not included in the repo. Not only this will eliminate some of the error messages, will also probably require less memory and time to to build the repo. Replacing the line Or maybe it can take the list of file types which are to be handled by hhvm, as an argument, in the absence of which a default list is used and build the find command. Also |
|
@paulbiss the repo is getting built. From initial testing it seems that things are ok. Since the references are from static/test files I think the repo file should be all right. But will appreciate if |
It's interesting that this library is not among those that couln't be statted. Of course, the library is present, readable and MediaWiki works in non-RepoAuthoritative mode.
|
|
@alex-mashin I also got the fatal error, but that also is not hhvm's fault.
I think If you try to find each file for which stating failed, you would find none of them exists and yet they are referenced in some of the text/php files, as I found out.
Of course the library is present, but
It is, but the code in SyntaxHighlight_GeSHi bundled with MW 1.25.1 stable release uses |
Yep, something like that, see #5833. It sounds like if we're smarter about which files to include, that will solve the bits of this that are actually solvable (i.e., not conditional includes for files that in fact don't exist). Going to close this in favor of #5833. |
Does it mean that HHVM in repo authoritative mode doesn't understand absolute namespaces? Or it's a bug in MediaWiki which plain HHVM or PHP somehow bypass?
The file is present in extensions/SyntaxHighlight_GeSHi/geshi. It is successfully included in non-RepoAuthoritative mode because somewhere the path to it is registered as include path. Perhaps, I should file a bug with SyntaxHighlight GeSHi. |
facebook/hhvm#5834 facebook/hhvm#5833 Change-Id: I138ffa5df874c5660897dc7feab36adef9f32aea
facebook/hhvm#5834 facebook/hhvm#5833 Change-Id: I138ffa5df874c5660897dc7feab36adef9f32aea
facebook/hhvm#5834 facebook/hhvm#5833 Change-Id: I138ffa5df874c5660897dc7feab36adef9f32aea
hhvm-repo-mode cannot stat some files from MediaWiki 1.25.1 and some of its important extensions: namely, PagedTiffHandler, Score, SemanticMediaWiki, SemanticResultFormats, SyntaxHighlight_GeSHi, TimedMediaHandler and Validator.
As a result, MediaWiki cannot be run in RepoAuthoritative mode.
List of files that cannot be stated below.
The text was updated successfully, but these errors were encountered: