Skip to content

Cancel animation when a custom Timeline is used #35567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebmarkbage merged 1 commit into from
Jan 20, 2026
Merged

Cancel animation when a custom Timeline is used #35567

sebmarkbage merged 1 commit into from
Jan 20, 2026
+3 −0

Conversation

@sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Jan 20, 2026

Follow up to #35559.

The clean up function of the custom timeline doesn't necessarily clean up the animation. Just the timeline's internal state.

This affects Firefox which doesn't support ScrollTimeline so uses the polyfill's custom timeline.

@sebmarkbage
Cancel animation when a custom Timeline is used
817bd79 
The clean up function of the custom timeline doesn't necessarily clean up
the animation. Just the timeline's internal state.
@sebmarkbage sebmarkbage requested a review from acdlite January 20, 2026 01:52
@meta-cla meta-cla bot added the CLA Signed label Jan 20, 2026
@sebmarkbage sebmarkbage merged commit d290875 into facebook:main Jan 20, 2026
14 of 15 checks passed
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jan 20, 2026
@react-sizebot
Copy link

react-sizebot commented Jan 20, 2026

Comparing: d343c39...817bd79

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.11% 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.73 kB 608.73 kB = 107.65 kB 107.65 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.05% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 674.61 kB 674.66 kB = 118.59 kB 118.59 kB
facebook-www/ReactDOM-prod.classic.js = 694.11 kB 694.11 kB = 122.02 kB 122.02 kB
facebook-www/ReactDOM-prod.modern.js = 684.50 kB 684.50 kB = 120.42 kB 120.42 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 817bd79

github-actions bot pushed a commit that referenced this pull request Jan 20, 2026
@sebmarkbage
Cancel animation when a custom Timeline is used (#35567)
6722cbc 
Follow up to #35559.

The clean up function of the custom timeline doesn't necessarily clean
up the animation. Just the timeline's internal state.

This affects Firefox which doesn't support ScrollTimeline so uses the
polyfill's custom timeline.

DiffTrain build for [d290875](d290875)
@nextjs-bot nextjs-bot mentioned this pull request Jan 20, 2026
Merged
sebmarkbage pushed a commit to vercel/next.js that referenced this pull request Jan 20, 2026
@nextjs-bot
Upgrade React from 41b3e9a6-20260119 to d2908752-20260119 (#88774)
9e33529 
[diff
facebook/react@41b3e9a6...d2908752](facebook/react@41b3e9a...d290875)

<details>
<summary>React upstream changes</summary>

- facebook/react#35567
- facebook/react#35566
- facebook/react#35565
- facebook/react#35564
- facebook/react#35559
- facebook/react#35556

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acdlite acdlite Awaiting requested review from acdlite

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sebmarkbage @react-sizebot