Add Clean Up Callbacks to View Transition and Gesture Transition Events #35564
+105
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
requested review from
acdlite,
gaearon,
jackpope and
rickhanlonii
github-actions
bot
added
the
React Core Team
acdlite
approved these changes
Jan 20, 2026
We need to fire the callbacks regardless of what stops it even if we are not the one to stop it.
sebmarkbage
force-pushed
the
vtrefcleanup
branch
from
9fdf2c7 to
e7ff876
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…ts (#35564) Stacked on #35556 and #35559. Given that we don't automatically clean up all view transition animations since #35337 and browsers are buggy, it's important that you clean up any `Animation` started manually from the events. However, there was no clean up function for when the View Transition is forced to stop. This also makes it harder to clean up custom timers etc too. This lets you return a clean up function from all the events on `<ViewTransition>`. DiffTrain build for [c55ffb5](c55ffb5)
Collaborator
Author
|
cc @eps1lon for DefinitelyTyped |
sebmarkbage
pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 20, 2026
[diff facebook/react@41b3e9a6...d2908752](facebook/react@41b3e9a...d290875) <details> <summary>React upstream changes</summary> - facebook/react#35567 - facebook/react#35566 - facebook/react#35565 - facebook/react#35564 - facebook/react#35559 - facebook/react#35556 </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #35556 and #35559.
Given that we don't automatically clean up all view transition animations since #35337 and browsers are buggy, it's important that you clean up any
Animationstarted manually from the events. However, there was no clean up function for when the View Transition is forced to stop. This also makes it harder to clean up custom timers etc too.This lets you return a clean up function from all the events on
<ViewTransition>.