Skip to content

[DevTools] Lazily compute initial Tree state #34078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

[DevTools] Lazily compute initial Tree state #34078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 49 additions & 26 deletions packages/react-devtools-shared/src/devtools/views/Components/TreeContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,45 @@ type Props = {
defaultInspectedElementIndex?: ?number,
};

function getInitialState({
defaultOwnerID,
defaultInspectedElementID,
defaultInspectedElementIndex,
store,
}: {
defaultOwnerID?: ?number,
defaultInspectedElementID?: ?number,
defaultInspectedElementIndex?: ?number,
store: Store,
}): State {
return {
// Tree
numElements: store.numElements,
ownerSubtreeLeafElementID: null,

// Search
searchIndex: null,
searchResults: [],
searchText: '',

// Owners
ownerID: defaultOwnerID == null ? null : defaultOwnerID,
ownerFlatTree: null,

// Inspection element panel
inspectedElementID:
defaultInspectedElementID != null
? defaultInspectedElementID
: store.lastSelectedHostInstanceElementId,
inspectedElementIndex:
defaultInspectedElementIndex != null
? defaultInspectedElementIndex
: store.lastSelectedHostInstanceElementId
? store.getIndexOfElementID(store.lastSelectedHostInstanceElementId)
: null,
};
}

// TODO Remove TreeContextController wrapper element once global Context.write API exists.
function TreeContextController({
children,
Expand Down Expand Up @@ -866,32 +905,16 @@ function TreeContextController({
[store],
);

const [state, dispatch] = useReducer(reducer, {
// Tree
numElements: store.numElements,
ownerSubtreeLeafElementID: null,

// Search
searchIndex: null,
searchResults: [],
searchText: '',

// Owners
ownerID: defaultOwnerID == null ? null : defaultOwnerID,
ownerFlatTree: null,

// Inspection element panel
inspectedElementID:
defaultInspectedElementID != null
? defaultInspectedElementID
: store.lastSelectedHostInstanceElementId,
inspectedElementIndex:
defaultInspectedElementIndex != null
? defaultInspectedElementIndex
: store.lastSelectedHostInstanceElementId
? store.getIndexOfElementID(store.lastSelectedHostInstanceElementId)
Copy link
Collaborator Author

@eps1lon eps1lon Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where the warning originates from. We didn't use that index anymore since we no longer relied on the default state yet the warning continued to be issue. It should only be issued when we actually use a problematic value.

: null,
});
const [state, dispatch] = useReducer(
reducer,
{
defaultOwnerID,
defaultInspectedElementID,
defaultInspectedElementIndex,
store,
},
getInitialState,
);
const transitionDispatch = useMemo(
() => (action: Action) =>
startTransition(() => {
Expand Down
Loading