[DevTools] Lazily compute initial Tree state #34078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Aug 1, 2025
| defaultInspectedElementIndex != null | ||
| ? defaultInspectedElementIndex | ||
| : store.lastSelectedHostInstanceElementId | ||
| ? store.getIndexOfElementID(store.lastSelectedHostInstanceElementId) |
Collaborator
Author
There was a problem hiding this comment.
This is where the warning originates from. We didn't use that index anymore since we no longer relied on the default state yet the warning continued to be issue. It should only be issued when we actually use a problematic value.
hoxyq
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we start out with no inspected element, we default to the last selected host instance. However, this can be an instance that is no longer rendered issuing warnings when we try to get its index.
Even though we no longer inspect that element, rendering the TreeContextController would issue warnings since the default state was computed on every render.
This gets rid of the warning by lazily computing the state.