Skip to content

Clean up feature flag to use lazy public instances in Fabric #33943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sammy-SC merged 2 commits into from
Jul 21, 2025
Merged

Clean up feature flag to use lazy public instances in Fabric #33943

sammy-SC merged 2 commits into from
Jul 21, 2025

Conversation

@rubennorte
Copy link
Contributor

@rubennorte rubennorte commented Jul 18, 2025

Summary

We have thoroughly tested this flag in production and proved stability and performance, so we can clean it up and "ship it".

@rubennorte rubennorte requested a review from javache July 18, 2025 16:34
@meta-cla meta-cla bot added the CLA Signed label Jul 18, 2025
@rubennorte rubennorte requested review from hoxyq and sammy-SC July 18, 2025 16:34
@react-sizebot
Copy link

react-sizebot commented Jul 18, 2025 •
edited
Loading

Comparing: dffacc7...edb5d73

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.70 kB 530.70 kB = 93.70 kB 93.70 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.25 kB 655.25 kB = 115.40 kB 115.40 kB
facebook-www/ReactDOM-prod.classic.js = 675.13 kB 675.13 kB = 118.75 kB 118.75 kB
facebook-www/ReactDOM-prod.modern.js = 665.56 kB 665.56 kB = 117.11 kB 117.11 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against edb5d73

@sammy-SC sammy-SC merged commit e9638c3 into facebook:main Jul 21, 2025
244 of 245 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 21, 2025
@sammy-SC
Clean up feature flag to use lazy public instances in Fabric (#33943)
c8dd9b6 
## Summary

We have thoroughly tested this flag in production and proved stability
and performance, so we can clean it up and "ship it".

DiffTrain build for [e9638c3](e9638c3)
@rubennorte rubennorte deleted the cleanup-lazy-public-instances-flag branch July 21, 2025 09:48
@nextjs-bot nextjs-bot mentioned this pull request Jul 21, 2025
Merged
github-actions bot pushed a commit to code/lib-react that referenced this pull request Jul 27, 2025
@pull
Clean up feature flag to use lazy public instances in Fabric (faceboo…
f891b68 
…k#33943)

## Summary

We have thoroughly tested this flag in production and proved stability
and performance, so we can clean it up and "ship it".

DiffTrain build for [e9638c3](facebook@e9638c3)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Jul 27, 2025
@pull
Clean up feature flag to use lazy public instances in Fabric (faceboo…
93798eb 
…k#33943)

## Summary

We have thoroughly tested this flag in production and proved stability
and performance, so we can clean it up and "ship it".

DiffTrain build for [e9638c3](facebook@e9638c3)
@sebmarkbage sebmarkbage mentioned this pull request Aug 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sammy-SC sammy-SC sammy-SC approved these changes

@javache javache Awaiting requested review from javache

@hoxyq hoxyq Awaiting requested review from hoxyq

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte @react-sizebot @sammy-SC