Skip to content

[flags] remove enableOwnerStacks #32426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2025
Merged

[flags] remove enableOwnerStacks #32426

merged 2 commits into from
Mar 4, 2025

Conversation

@rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Feb 19, 2025 •
edited
Loading

Bassed off: #32425

Wait to land internally.

Commit to review.

This has landed everywhere

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 19, 2025
@rickhanlonii rickhanlonii force-pushed the rh/remove-ff-owner-stacks branch from 77946d4 to 4a1c5b4 Compare February 23, 2025 22:56
@react-sizebot
Copy link

react-sizebot commented Feb 23, 2025 •
edited
Loading

Comparing: d48c692...4c85bc3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 518.32 kB 518.32 kB = 92.45 kB 92.45 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 573.25 kB 573.25 kB = 102.08 kB 102.08 kB
facebook-www/ReactDOM-prod.classic.js = 641.70 kB 638.14 kB = 112.86 kB 112.31 kB
facebook-www/ReactDOM-prod.modern.js = 632.02 kB 628.46 kB = 111.30 kB 110.73 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react/cjs/react.react-server.development.js = 28.92 kB 28.86 kB = 6.96 kB 6.94 kB
oss-stable-semver/react/cjs/react.react-server.development.js = 28.90 kB 28.84 kB = 6.93 kB 6.91 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 133.90 kB 133.60 kB = 31.23 kB 31.18 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 133.88 kB 133.57 kB = 31.21 kB 31.15 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 145.49 kB 145.15 kB = 34.12 kB 34.06 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,138.54 kB 1,134.27 kB = 190.99 kB 190.35 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,129.40 kB 1,125.13 kB = 189.26 kB 188.63 kB
facebook-www/ReactDOM-dev.classic.js = 1,121.64 kB 1,117.36 kB = 187.14 kB 186.50 kB
facebook-www/ReactDOM-dev.modern.js = 1,112.50 kB 1,108.22 kB = 185.40 kB 184.76 kB
test_utils/ReactAllWarnings.js = 63.52 kB 63.23 kB = 15.90 kB 15.83 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 12.70 kB 12.64 kB = 3.44 kB 3.42 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 12.70 kB 12.64 kB = 3.44 kB 3.42 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.development.js = 12.15 kB 12.09 kB = 3.32 kB 3.30 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js = 12.15 kB 12.09 kB = 3.32 kB 3.30 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.development.js = 12.01 kB 11.95 kB = 3.28 kB 3.26 kB
oss-stable/react/cjs/react-jsx-dev-runtime.react-server.development.js = 12.01 kB 11.95 kB = 3.28 kB 3.26 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js = 12.00 kB 11.94 kB = 3.28 kB 3.25 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js = 12.00 kB 11.94 kB = 3.28 kB 3.25 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js = 11.53 kB 11.47 kB = 3.19 kB 3.17 kB
facebook-www/ReactDOM-profiling.classic.js = 669.14 kB 665.58 kB = 116.77 kB 116.21 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js = 11.38 kB 11.32 kB = 3.15 kB 3.13 kB
oss-stable/react/cjs/react-jsx-runtime.development.js = 11.38 kB 11.32 kB = 3.15 kB 3.13 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js = 11.33 kB 11.27 kB = 3.17 kB 3.15 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 11.32 kB 11.26 kB = 3.11 kB 3.09 kB
facebook-www/ReactDOM-profiling.modern.js = 659.41 kB 655.85 kB = 115.18 kB 114.61 kB
facebook-www/ReactDOMTesting-prod.classic.js = 656.42 kB 652.86 kB = 116.58 kB 116.02 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js = 11.18 kB 11.12 kB = 3.13 kB 3.11 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js = 11.18 kB 11.12 kB = 3.13 kB 3.11 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 11.12 kB 11.06 kB = 3.09 kB 3.07 kB
facebook-www/ReactDOMTesting-prod.modern.js = 646.74 kB 643.18 kB = 115.01 kB 114.44 kB
facebook-www/ReactDOM-prod.classic.js = 641.70 kB 638.14 kB = 112.86 kB 112.31 kB
facebook-www/ReactDOM-prod.modern.js = 632.02 kB 628.46 kB = 111.30 kB 110.73 kB

Generated by 🚫 dangerJS against 5855c6d

@rickhanlonii rickhanlonii force-pushed the rh/remove-ff-owner-stacks branch from 4a1c5b4 to 4395e47 Compare February 23, 2025 23:08
@rickhanlonii rickhanlonii force-pushed the rh/remove-ff-owner-stacks branch from 4395e47 to c4da3fd Compare February 23, 2025 23:25
rickhanlonii
rickhanlonii commented Feb 23, 2025
View reviewed changes
packages/react-devtools-shared/src/backend/fiber/DevToolsFiberComponentStack.js Outdated
return !!fiber._debugTask;
}

// TODO: clean this up?
Copy link
Member Author

@rickhanlonii rickhanlonii Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebmarkbage is it safe for me to delete this? Not sure about devtools versioning

Copy link
Collaborator

@sebmarkbage sebmarkbage Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not safe to delete because this is the feature detection whether this version of React supports owner stacks or not.

@rickhanlonii rickhanlonii force-pushed the rh/remove-ff-owner-stacks branch from c4da3fd to 66aa6a4 Compare February 23, 2025 23:52
@rickhanlonii rickhanlonii force-pushed the rh/remove-ff-owner-stacks branch from 66aa6a4 to 886812d Compare February 24, 2025 15:01
sebmarkbage
sebmarkbage reviewed Feb 24, 2025
View reviewed changes
@rickhanlonii rickhanlonii force-pushed the rh/remove-ff-owner-stacks branch from 886812d to 73596c8 Compare March 4, 2025 17:15
@rickhanlonii rickhanlonii force-pushed the rh/remove-ff-owner-stacks branch from 73596c8 to 5855c6d Compare March 4, 2025 17:27
@rickhanlonii rickhanlonii merged commit e0fe347 into facebook:main Mar 4, 2025
194 checks passed
@rickhanlonii rickhanlonii deleted the rh/remove-ff-owner-stacks branch March 4, 2025 17:34
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
@rickhanlonii
[flags] remove enableOwnerStacks (#32426)
c253047 
Bassed off: #32425

Wait to land internally.

[Commit to
review.](66aa6a4)

This has landed everywhere

DiffTrain build for [e0fe347](e0fe347)
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
@rickhanlonii
[flags] remove enableOwnerStacks (#32426)
6fa2e00 
Bassed off: #32425

Wait to land internally.

[Commit to
review.](66aa6a4)

This has landed everywhere

DiffTrain build for [e0fe347](e0fe347)
@vercel-release-bot vercel-release-bot mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@hoxyq hoxyq hoxyq left review comments

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rickhanlonii @react-sizebot @sebmarkbage @hoxyq @facebook-github-bot