Skip to content

[flags] remove enableRemoveConsolePatches #32425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

[flags] remove enableRemoveConsolePatches #32425

merged 1 commit into from
Feb 24, 2025

Conversation

@rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Feb 19, 2025

wait to merge until we sync #32376, since that enables it in some testing builds that might break

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 19, 2025
@react-sizebot
Copy link

react-sizebot commented Feb 19, 2025

Comparing: a84862d...9e1e87e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.71 kB 515.71 kB = 92.09 kB 92.09 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 562.25 kB 562.25 kB = 100.08 kB 100.08 kB
facebook-www/ReactDOM-prod.classic.js = 636.70 kB 636.70 kB = 112.08 kB 112.08 kB
facebook-www/ReactDOM-prod.modern.js = 627.02 kB 627.02 kB = 110.50 kB 110.50 kB
facebook-www/React-dev.classic.js = 56.79 kB 55.47 kB = 12.42 kB 12.09 kB
facebook-www/React-dev.modern.js = 56.79 kB 55.47 kB = 12.42 kB 12.09 kB
facebook-react-native/react/cjs/React-dev.js = 52.36 kB 51.09 kB = 11.71 kB 11.38 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js = 17.57 kB 16.74 kB = 3.90 kB 3.60 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 13.52 kB 12.70 kB = 3.69 kB 3.44 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 13.52 kB 12.70 kB = 3.69 kB 3.44 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 12.08 kB 11.32 kB = 3.36 kB 3.11 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 11.88 kB 11.12 kB = 3.34 kB 3.09 kB
facebook-www/ReactReconcilerConstants-dev.classic.js = 0.63 kB 0.58 kB = 0.35 kB 0.33 kB
facebook-www/ReactReconcilerConstants-dev.modern.js = 0.63 kB 0.58 kB = 0.35 kB 0.33 kB
facebook-www/ReactCacheOld-dev.classic.js = 7.35 kB 6.32 kB = 2.12 kB 1.82 kB
facebook-www/ReactCacheOld-dev.modern.js = 7.35 kB 6.32 kB = 2.12 kB 1.82 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-dev.js = 1.80 kB 0.75 kB = 0.84 kB 0.44 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMTesting-dev.classic.js = 1,134.88 kB 1,132.23 kB = 190.74 kB 190.08 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,125.73 kB 1,123.08 kB = 189.03 kB 188.36 kB
facebook-www/ReactDOM-dev.classic.js = 1,117.97 kB 1,115.32 kB = 186.90 kB 186.22 kB
facebook-www/ReactDOM-dev.modern.js = 1,108.83 kB 1,106.18 kB = 185.15 kB 184.48 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js = 1,009.20 kB 1,006.57 kB = 169.87 kB 169.26 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js = 992.85 kB 990.25 kB = 167.03 kB 166.44 kB
facebook-www/ReactReconciler-dev.classic.js = 771.74 kB 769.22 kB = 121.51 kB 120.81 kB
facebook-www/ReactReconciler-dev.modern.js = 762.53 kB 760.02 kB = 119.84 kB 119.14 kB
react-native/implementations/ReactFabric-dev.fb.js = 671.82 kB 669.54 kB = 109.37 kB 108.85 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 677.10 kB 674.72 kB = 110.40 kB 109.79 kB
react-native/implementations/ReactFabric-dev.js = 642.02 kB 639.75 kB = 104.88 kB 104.34 kB
facebook-www/ReactART-dev.classic.js = 667.54 kB 665.13 kB = 106.24 kB 105.57 kB
facebook-www/ReactART-dev.modern.js = 658.04 kB 655.63 kB = 104.39 kB 103.73 kB
react-native/implementations/ReactNativeRenderer-dev.js = 650.57 kB 648.02 kB = 106.36 kB 105.73 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 599.85 kB 597.27 kB = 96.96 kB 96.35 kB
facebook-www/ReactTestRenderer-dev.classic.js = 576.77 kB 574.27 kB = 94.20 kB 93.55 kB
facebook-www/ReactTestRenderer-dev.modern.js = 576.76 kB 574.27 kB = 94.20 kB 93.55 kB
facebook-www/ReactDOMServer-dev.classic.js = 379.50 kB 377.77 kB = 68.11 kB 67.64 kB
facebook-www/ReactDOMServer-dev.modern.js = 372.65 kB 370.92 kB = 67.10 kB 66.67 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js = 364.35 kB 362.62 kB = 65.82 kB 65.37 kB
facebook-www/React-dev.classic.js = 56.79 kB 55.47 kB = 12.42 kB 12.09 kB
facebook-www/React-dev.modern.js = 56.79 kB 55.47 kB = 12.42 kB 12.09 kB
facebook-react-native/react/cjs/React-dev.js = 52.36 kB 51.09 kB = 11.71 kB 11.38 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js = 17.57 kB 16.74 kB = 3.90 kB 3.60 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 13.52 kB 12.70 kB = 3.69 kB 3.44 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 13.52 kB 12.70 kB = 3.69 kB 3.44 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 12.08 kB 11.32 kB = 3.36 kB 3.11 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 11.88 kB 11.12 kB = 3.34 kB 3.09 kB
facebook-www/ReactReconcilerConstants-dev.classic.js = 0.63 kB 0.58 kB = 0.35 kB 0.33 kB
facebook-www/ReactReconcilerConstants-dev.modern.js = 0.63 kB 0.58 kB = 0.35 kB 0.33 kB
facebook-www/ReactCacheOld-dev.classic.js = 7.35 kB 6.32 kB = 2.12 kB 1.82 kB
facebook-www/ReactCacheOld-dev.modern.js = 7.35 kB 6.32 kB = 2.12 kB 1.82 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-dev.js = 1.80 kB 0.75 kB = 0.84 kB 0.44 kB

Generated by 🚫 dangerJS against 739ff9d

@rickhanlonii rickhanlonii mentioned this pull request Feb 19, 2025
Merged
@rickhanlonii rickhanlonii merged commit 2567726 into facebook:main Feb 24, 2025
196 checks passed
@rickhanlonii rickhanlonii deleted the rh/remove-console-patch branch February 24, 2025 15:01
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@rickhanlonii
[flags] remove enableRemoveConsolePatches (#32425)
920b646 
wait to merge until we sync
#32376, since that enables it in
some testing builds that might break

DiffTrain build for [2567726](2567726)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@rickhanlonii
[flags] remove enableRemoveConsolePatches (#32425)
6d9586c 
wait to merge until we sync
#32376, since that enables it in
some testing builds that might break

DiffTrain build for [2567726](2567726)
@vercel-release-bot vercel-release-bot mentioned this pull request Feb 24, 2025
Merged
rickhanlonii added a commit that referenced this pull request Mar 4, 2025
@rickhanlonii
[flags] remove enableOwnerStacks (#32426)
e0fe347 
Bassed off: #32425

Wait to land internally.

[Commit to
review.](66aa6a4)

This has landed everywhere
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
@rickhanlonii
[flags] remove enableOwnerStacks (#32426)
c253047 
Bassed off: #32425

Wait to land internally.

[Commit to
review.](66aa6a4)

This has landed everywhere

DiffTrain build for [e0fe347](e0fe347)
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
@rickhanlonii
[flags] remove enableOwnerStacks (#32426)
6fa2e00 
Bassed off: #32425

Wait to land internally.

[Commit to
review.](66aa6a4)

This has landed everywhere

DiffTrain build for [e0fe347](e0fe347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kassens kassens kassens approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickhanlonii @react-sizebot @kassens @facebook-github-bot