Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Collect temporaries and optional chains from inner functions #31346

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[compiler] Collect temporaries and optional chains from inner functions #31346

wants to merge 4 commits into from

Commits on Oct 24, 2024

  1. [compiler][ez] Patch hoistability for ObjectMethods 

    Extends #31066 to ObjectMethods (somehow missed this before).

'
    @mofeiZ
    mofeiZ committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d0c31e9 View commit details
    Browse the repository at this point in the history

  2. [compiler] bugfix for hoistable deps for nested functions 

    `PropertyPathRegistry` is responsible for uniqueing identifier and property paths. This is necessary for the hoistability CFG merging logic which takes unions and intersections of these nodes to determine a basic block's hoistable reads, as a function of its neighbors. We also depend on this to merge optional chained and non-optional chained property paths

This fixes a small bug in #31066 in which we create a new registry for nested functions. Now, we use the same registry for a component / hook and all its inner functions

'
    @mofeiZ
    mofeiZ committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ce0115c View commit details
    Browse the repository at this point in the history

  3. [compiler] Delete propagateScopeDeps (non-hir) 

    `enablePropagateScopeDepsHIR` is now used extensively in Meta. This has been tested for over two weeks in our e2e tests and production.

The rest of this stack deletes `LoweredFunction.dependencies`, which the non-hir version of `PropagateScopeDeps` depends on. To avoid a more forked HIR (non-hir with dependencies and hir with no dependencies), let's go ahead and clean up the non-hir version of PropagateScopeDepsHIR.

Note that all fixture changes in this PR were previously reviewed when they were copied to `propagate-scope-deps-hir-fork`. Will clean up / merge these duplicate fixtures in a later PR

'
    @mofeiZ
    mofeiZ committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    640c52e View commit details
    Browse the repository at this point in the history

  4. [compiler] Collect temporaries and optional chains from inner functions 

    Recursively collect identifier / property loads and optional chains from inner functions. This PR is in preparation for #31200

Previously, we only did this in `collectHoistablePropertyLoads` to understand hoistable property loads from inner functions.
1. collectTemporariesSidemap
2. collectOptionalChainSidemap
3. collectHoistablePropertyLoads
    - ^ this recursively calls `collectTemporariesSidemap`, `collectOptionalChainSidemap`, and `collectOptionalChainSidemap` on inner functions
4. collectDependencies

Now, we have
1. collectTemporariesSidemap
    - recursively record identifiers in inner functions. Note that we track all temporaries in the same map as `IdentifierIds` are currently unique across functions
2. collectOptionalChainSidemap
    - recursively records optional chain sidemaps in inner functions
3. collectHoistablePropertyLoads
    - (unchanged, except to remove recursive collection of temporaries)
4. collectDependencies
    - unchanged: to be modified to recursively collect dependencies in next PR

'
    @mofeiZ
    mofeiZ committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0d4afc5 View commit details
    Browse the repository at this point in the history