[compiler] Stop using function dependencies in propagateScopeDeps
#31200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Oct 11, 2024
facebook-github-bot
added
CLA Signed
React Core Team
mofeiZ
changed the title
dependencies in propagateScopeDeps
This was referenced Oct 24, 2024
mofeiZ
force-pushed
the
pr31200
branch
2 times, most recently
from
a84a59d
to
c5b7421
Compare
Extends #31066 to ObjectMethods (somehow missed this before). '
`PropertyPathRegistry` is responsible for uniqueing identifier and property paths. This is necessary for the hoistability CFG merging logic which takes unions and intersections of these nodes to determine a basic block's hoistable reads, as a function of its neighbors. We also depend on this to merge optional chained and non-optional chained property paths This fixes a small bug in #31066 in which we create a new registry for nested functions. Now, we use the same registry for a component / hook and all its inner functions '
`enablePropagateScopeDepsHIR` is now used extensively in Meta. This has been tested for over two weeks in our e2e tests and production. The rest of this stack deletes `LoweredFunction.dependencies`, which the non-hir version of `PropagateScopeDeps` depends on. To avoid a more forked HIR (non-hir with dependencies and hir with no dependencies), let's go ahead and clean up the non-hir version of PropagateScopeDepsHIR. Note that all fixture changes in this PR were previously reviewed when they were copied to `propagate-scope-deps-hir-fork`. Will clean up / merge these duplicate fixtures in a later PR '
Recursively collect identifier / property loads and optional chains from inner functions. This PR is in preparation for #31200 Previously, we only did this in `collectHoistablePropertyLoads` to understand hoistable property loads from inner functions. 1. collectTemporariesSidemap 2. collectOptionalChainSidemap 3. collectHoistablePropertyLoads - ^ this recursively calls `collectTemporariesSidemap`, `collectOptionalChainSidemap`, and `collectOptionalChainSidemap` on inner functions 4. collectDependencies Now, we have 1. collectTemporariesSidemap - recursively record identifiers in inner functions. Note that we track all temporaries in the same map as `IdentifierIds` are currently unique across functions 2. collectOptionalChainSidemap - recursively records optional chain sidemaps in inner functions 3. collectHoistablePropertyLoads - (unchanged, except to remove recursive collection of temporaries) 4. collectDependencies - unchanged: to be modified to recursively collect dependencies in next PR '
Recursively visit inner function instructions to extract dependencies instead of using `LoweredFunction.dependencies` directly. This is currently gated by enableFunctionDependencyRewrite, which needs to be removed before we delete `LoweredFunction.dependencies` altogether (#31204). Some nice side effects - optional-chaining deps for inner functions - full DCE and outlining for inner functions (see #31202) - fewer extraneous instructions (see #31204) -
mofeiZ
commented
Oct 26, 2024
| @@ -230,6 +230,8 @@ const EnvironmentConfigSchema = z.object({ | |||
| */ | |||
| enableUseTypeAnnotations: z.boolean().default(false), | |||
|
|
|||
| enableFunctionDependencyRewrite: z.boolean().default(true), | |||
There was a problem hiding this comment.
Note that this is deleted in #31204
mofeiZ
commented
Oct 26, 2024
| const maybeOptionalChain = temporaries.get(operand[1].identifier.id); | ||
| if (maybeOptionalChain) { | ||
| context.visitDependency(maybeOptionalChain); | ||
| const handleFunction = (fn: HIRFunction): void => { |
There was a problem hiding this comment.
This change is code movement (moving logic into handleFunction) so that we can recursively visit nested functions
mofeiZ
commented
Oct 26, 2024
Comment on lines
+705
to
+707
| context.inInnerFn = true; | ||
| handleFunction(instr.value.loweredFunc.func); | ||
| context.inInnerFn = wasInInnerFn; |
There was a problem hiding this comment.
Recursive call. See explanation in Context.#declare for why inInnerFn is needed
mofeiZ
commented
Oct 26, 2024
| } | ||
| const y = t0; | ||
| const $ = _c(2); | ||
| const y = { b }; |
There was a problem hiding this comment.
const y = { b } is dce'd in #31204 (after we delete LoweredFunction.dependencies)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursively visit inner function instructions to extract dependencies instead of using
LoweredFunction.dependenciesdirectly.This is currently gated by enableFunctionDependencyRewrite, which needs to be removed before we delete
LoweredFunction.dependenciesaltogether (#31204).Some nice side effects
optional-chaining deps for inner functions
full DCE and outlining for inner functions (see [compiler][be] Clean up nested function context in DCE #31202)
fewer extraneous instructions (see [compiler] Delete LoweredFunction.dependencies and hoisted instructions #31204)
Stack created with Sapling. Best reviewed with ReviewStack.
dependenciesin propagateScopeDeps #31200