Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update release scripts for react devtools #31069

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Sep 26, 2024

This has been broken since the migration to GitHub actions.

Previously, we've been using buildId as an identifier from CircleCI. I've decided to use a commit hash as an identifier, because I don't know if there is a better option, and scripts/release/download_build_artifacts.js allows us to download them for a specific commit.

@hoxyq hoxyq requested a review from poteto September 26, 2024 08:54
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 26, 2024
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:57am

@react-sizebot
Copy link

Comparing: 778e1ed...7a29020

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 507.20 kB 507.20 kB = 90.80 kB 90.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.13 kB 512.13 kB = 91.52 kB 91.52 kB
facebook-www/ReactDOM-prod.classic.js = 603.73 kB 603.73 kB = 106.83 kB 106.83 kB
facebook-www/ReactDOM-prod.modern.js = 579.95 kB 579.95 kB = 102.92 kB 102.92 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 77b48dc

Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks for fixing!

@hoxyq hoxyq merged commit b091ef7 into facebook:main Sep 26, 2024
184 checks passed
@hoxyq hoxyq deleted the react-devtools/update-release-scripts branch September 26, 2024 14:43
gnoff added a commit to vercel/next.js that referenced this pull request Sep 27, 2024
abhi12299 pushed a commit to abhi12299/next.js that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants