fix: use public instance in Fiber renderer and expose it from getInspectorDataForViewAtPoint #31068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectorDataForViewAtPoint
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 778e1ed...0180849 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
hoxyq
commented
Sep 26, 2024
Comment on lines
+775
to
+776
| typeof instance.canonical.publicInstance === 'object' && | ||
| instance.canonical.publicInstance !== null |
There was a problem hiding this comment.
Can this be a non-object? In Legacy Fabric, for example?
There was a problem hiding this comment.
Not AFAIK. And canonical is only available in Fabric.
rubennorte
reviewed
Sep 26, 2024
| if (typeof instance === 'object' && instance !== null) { | ||
| if (typeof instance.canonical === 'object' && instance.canonical !== null) { | ||
| if ( | ||
| typeof instance.canonical.publicInstance === 'object' && |
There was a problem hiding this comment.
Nit: you can reduce nesting here combining the conditions
There was a problem hiding this comment.
Yeah, I've decided to do nesting instead, because combining will produce a very long line, looks a bit uglier :(
hoxyq
deleted the
react-native/expose-public-instance-from-inspector-data-for-view-at-point
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
…ectorDataForViewAtPoint (#31068) React DevTools no longer operates with just Fibers, it now builds its own Shadow Tree, which represents the tree on the Host (Fabric on Native, DOM on Web). We have to keep track of public instances for a select-to-inspect feature. We've recently changed this logic in #30831, and looks like we've been incorrectly getting a public instance for Fabric case. Not only this, turns out that all `getInspectorData...` APIs are returning Fibers, and not public instances. I have to expose it, so that React DevTools can correctly identify the element, which was selected. Changes for React Native are in [D63421463](https://www.internalfb.com/diff/D63421463) DiffTrain build for commit d66fa02.
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Sep 26, 2024
Summary: # Changelog: [Internal] Please see facebook/react#31068. Synced changes for React Native - D63453667. Differential Revision: D63421463
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: facebook#46664 # Changelog: [Internal] Please see facebook/react#31068. Synced changes for React Native - D63453667. Differential Revision: D63421463
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: facebook#46664 # Changelog: [Internal] Please see facebook/react#31068. Synced changes for React Native - D63453667. Differential Revision: D63421463
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: facebook#46664 # Changelog: [Internal] Please see facebook/react#31068. Synced changes for React Native - D63453667. Reviewed By: huntie Differential Revision: D63421463
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#46664 # Changelog: [Internal] Please see facebook/react#31068. Synced changes for React Native - D63453667. Reviewed By: huntie Differential Revision: D63421463
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: #46664 # Changelog: [Internal] Please see facebook/react#31068. Synced changes for React Native - D63453667. Reviewed By: huntie Differential Revision: D63421463 fbshipit-source-id: e455711206598a06f7cdce4150e79c3548843b99
gnoff
added a commit
to vercel/next.js
that referenced
this pull request
Sep 27, 2024
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-778e1ed2-20240926` to `19.0.0-rc-3edc000d-20240926`** [diff facebook/react@778e1ed2...3edc000d](facebook/react@778e1ed...3edc000) <details> <summary>React upstream changes</summary> - facebook/react#31078 - facebook/react#31083 - facebook/react#31079 - facebook/react#31080 - facebook/react#31076 - facebook/react#31021 - facebook/react#31069 - facebook/react#31074 - facebook/react#31073 - facebook/react#31047 - facebook/react#31046 - facebook/react#31045 - facebook/react#31072 - facebook/react#30980 - facebook/react#30463 - facebook/react#30694 - facebook/react#31039 - facebook/react#31048 - facebook/react#31068 </details> --------- Co-authored-by: Josh Story <[email protected]>
abhi12299
pushed a commit
to abhi12299/next.js
that referenced
this pull request
Sep 29, 2024
…#70560) **breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-778e1ed2-20240926` to `19.0.0-rc-3edc000d-20240926`** [diff facebook/react@778e1ed2...3edc000d](facebook/react@778e1ed...3edc000) <details> <summary>React upstream changes</summary> - facebook/react#31078 - facebook/react#31083 - facebook/react#31079 - facebook/react#31080 - facebook/react#31076 - facebook/react#31021 - facebook/react#31069 - facebook/react#31074 - facebook/react#31073 - facebook/react#31047 - facebook/react#31046 - facebook/react#31045 - facebook/react#31072 - facebook/react#30980 - facebook/react#30463 - facebook/react#30694 - facebook/react#31039 - facebook/react#31048 - facebook/react#31068 </details> --------- Co-authored-by: Josh Story <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React DevTools no longer operates with just Fibers, it now builds its own Shadow Tree, which represents the tree on the Host (Fabric on Native, DOM on Web).
We have to keep track of public instances for a select-to-inspect feature. We've recently changed this logic in #30831, and looks like we've been incorrectly getting a public instance for Fabric case.
Not only this, turns out that all
getInspectorData...APIs are returning Fibers, and not public instances. I have to expose it, so that React DevTools can correctly identify the element, which was selected.Changes for React Native are in D63421463