Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight Reply] Resolve outlined models async in Reply just like in Flight Client #28988

Merged
merged 1 commit into from
May 8, 2024
Merged

[Flight Reply] Resolve outlined models async in Reply just like in Flight Client #28988

merged 1 commit into from
May 8, 2024
+154 −43

Conversation

sebmarkbage
Copy link
Collaborator

This is the same change as #28780 but for the Flight Reply receiver.

While it's not possible to create an "async module" reference in this case - resolving a server reference can still be async if loading it requires loading chunks like in a new server instance.

Since extracting a typed array from a Blob is async, that's also a case where a dependency can be async.

@sebmarkbage sebmarkbage requested a review from gnoff May 3, 2024 18:56
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 3, 2024
@react-sizebot
Copy link

react-sizebot commented May 3, 2024 •
edited
Loading

Comparing: 6bac4f2...55efea7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 494.06 kB 494.06 kB = 88.22 kB 88.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 498.86 kB 498.86 kB = 88.93 kB 88.93 kB
facebook-www/ReactDOM-prod.classic.js = 591.22 kB 591.22 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 567.44 kB 567.44 kB = 100.36 kB 100.36 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js +0.38% 83.70 kB 84.02 kB +0.41% 17.26 kB 17.33 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js +0.38% 85.69 kB 86.01 kB +0.39% 17.38 kB 17.45 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +0.37% 86.57 kB 86.89 kB +0.39% 17.63 kB 17.70 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js +0.37% 86.77 kB 87.09 kB +0.40% 17.62 kB 17.69 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +0.37% 87.30 kB 87.63 kB +0.39% 17.77 kB 17.84 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js +0.37% 62.45 kB 62.68 kB +0.44% 13.97 kB 14.03 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js +0.37% 62.45 kB 62.68 kB +0.44% 13.97 kB 14.03 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js +0.36% 88.50 kB 88.82 kB +0.37% 18.01 kB 18.08 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js +0.36% 63.67 kB 63.90 kB +0.41% 13.99 kB 14.05 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js +0.36% 63.67 kB 63.90 kB +0.41% 13.99 kB 14.05 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js +0.36% 89.46 kB 89.78 kB +0.37% 18.22 kB 18.29 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js +0.36% 89.60 kB 89.92 kB +0.35% 18.24 kB 18.30 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +0.36% 64.46 kB 64.69 kB +0.41% 14.23 kB 14.29 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +0.36% 64.46 kB 64.69 kB +0.41% 14.23 kB 14.29 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js +0.36% 90.55 kB 90.87 kB +0.37% 18.45 kB 18.52 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js +0.36% 64.75 kB 64.98 kB +0.38% 14.21 kB 14.26 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js +0.36% 64.75 kB 64.98 kB +0.38% 14.21 kB 14.26 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +0.35% 65.20 kB 65.43 kB +0.40% 14.36 kB 14.42 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +0.35% 65.20 kB 65.43 kB +0.40% 14.36 kB 14.42 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js +0.34% 67.26 kB 67.49 kB +0.40% 14.70 kB 14.76 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js +0.34% 67.26 kB 67.49 kB +0.40% 14.70 kB 14.76 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js +0.34% 68.22 kB 68.45 kB +0.42% 14.91 kB 14.97 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js +0.34% 68.22 kB 68.45 kB +0.42% 14.91 kB 14.97 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js +0.34% 68.35 kB 68.58 kB +0.41% 14.91 kB 14.97 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js +0.34% 68.35 kB 68.58 kB +0.41% 14.91 kB 14.97 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js +0.33% 69.30 kB 69.53 kB +0.43% 15.13 kB 15.20 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js +0.33% 69.30 kB 69.53 kB +0.43% 15.13 kB 15.20 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.21% 124.31 kB 124.57 kB +0.17% 28.75 kB 28.80 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.21% 124.31 kB 124.57 kB +0.17% 28.75 kB 28.80 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.21% 127.05 kB 127.31 kB +0.19% 29.29 kB 29.35 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.21% 127.05 kB 127.31 kB +0.19% 29.29 kB 29.35 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.20% 128.30 kB 128.56 kB +0.16% 29.58 kB 29.63 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.20% 128.30 kB 128.56 kB +0.16% 29.58 kB 29.63 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.20% 129.50 kB 129.76 kB +0.15% 29.96 kB 30.00 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.20% 129.50 kB 129.76 kB +0.15% 29.96 kB 30.00 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.20% 130.23 kB 130.49 kB +0.15% 30.08 kB 30.12 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.20% 130.23 kB 130.49 kB +0.15% 30.08 kB 30.12 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.20% 130.47 kB 130.73 kB +0.16% 29.75 kB 29.80 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.20% 130.47 kB 130.73 kB +0.16% 29.75 kB 29.80 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 55efea7

@sebmarkbage sebmarkbage force-pushed the fixreplyoutline branch 3 times, most recently from e3d4729 to 90a7f4d Compare May 3, 2024 21:21
@sebmarkbage sebmarkbage mentioned this pull request May 6, 2024
Merged
@sebmarkbage sebmarkbage merged commit ec15267 into facebook:main May 8, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request May 8, 2024
@sebmarkbage
[Flight Reply] Resolve outlined models async in Reply just like in Fl…
3229b97 
…ight Client (#28988)

This is the same change as #28780 but for the Flight Reply receiver.

While it's not possible to create an "async module" reference in this
case - resolving a server reference can still be async if loading it
requires loading chunks like in a new server instance.

Since extracting a typed array from a Blob is async, that's also a case
where a dependency can be async.

DiffTrain build for [ec15267](ec15267)
@eps1lon eps1lon mentioned this pull request May 16, 2024
Merged
eps1lon added a commit to vercel/next.js that referenced this pull request May 16, 2024
@eps1lon
Update React from 4508873393 to 04b058868c (#65864)
c045f0f 
Completes #65845 which only
updated Canary not Experimental.

<details>
<summary> React upstream changes</summary>

- facebook/react#29026
- facebook/react#29025
- facebook/react#28743
- facebook/react#29022
- facebook/react#29023
- facebook/react#29015
- facebook/react#29016
- facebook/react#28988
- facebook/react#28987
- facebook/react#28986
- facebook/react#29014
- facebook/react#28982
- facebook/react#29006
- facebook/react#28973
- facebook/react#28841
- facebook/react#28964
- facebook/react#28990
- facebook/react#29003
- facebook/react#28989
- facebook/react#28893
- facebook/react#28887
- facebook/react#28807
- facebook/react#28978
- facebook/react#28963
- facebook/react#28972
- facebook/react#28970
- facebook/react#28816
- facebook/react#28977
- facebook/react#28974
- facebook/react#28976
- facebook/react#28975
- facebook/react#28969
- facebook/react#28966
- facebook/react#28056

</details>
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
@eps1lon @panteliselef
Update React from 4508873393 to 04b058868c (vercel#65864)
1539871 
Completes vercel#65845 which only
updated Canary not Experimental.

<details>
<summary> React upstream changes</summary>

- facebook/react#29026
- facebook/react#29025
- facebook/react#28743
- facebook/react#29022
- facebook/react#29023
- facebook/react#29015
- facebook/react#29016
- facebook/react#28988
- facebook/react#28987
- facebook/react#28986
- facebook/react#29014
- facebook/react#28982
- facebook/react#29006
- facebook/react#28973
- facebook/react#28841
- facebook/react#28964
- facebook/react#28990
- facebook/react#29003
- facebook/react#28989
- facebook/react#28893
- facebook/react#28887
- facebook/react#28807
- facebook/react#28978
- facebook/react#28963
- facebook/react#28972
- facebook/react#28970
- facebook/react#28816
- facebook/react#28977
- facebook/react#28974
- facebook/react#28976
- facebook/react#28975
- facebook/react#28969
- facebook/react#28966
- facebook/react#28056

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff gnoff approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @gnoff @facebook-github-bot